Re: Spice for Libvirt

Re: Spice for Libvirt

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Tue, 2016-03-22 at 20:21 +0100, Jonatan Schlag wrote:
> 
> Hi,
> thank you for your feedback ,
> I will make a new patchset which includes the necessary corrections. 
> I have only one Question :
> 
> > 
> > All these python files actually belong to the spice-protocol package. They
> > are
> > just compiled and the bytecode files are generated when building this
> > package.
> > 
> > Could you check if you can do that after the install phase of the last
> > package?
> The bytecode is compiled with spice, in the moment, I understand that I should
> check I these files could generate with the spice-protocol package? Is this
> correct?

Yes, you should be able to generate them manually with something like
/usr/share/automake-*/py-compile.

-Michael

> 
> Regards Jonatan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Spice for Libvirt

[Jonatan Schlag]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]


This patch series contains all required packages for spice and spice itself. 
Spice provides a protocol similar to vnc but is faster and support more options (audio). 
I hope these patches are ok so far.

Just as a question how did the project deal with patches?
Should I wait till I get feedback for my first patches or should I send the next patches for libvirt?

Regards Jonatan

Re: Spice for Libvirt

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

Hi,

On Mon, 2016-03-21 at 19:47 +0100, Jonatan Schlag wrote:
> This patch series contains all required packages for spice and spice itself. 
> Spice provides a protocol similar to vnc but is faster and support more
> options (audio). 
> I hope these patches are ok so far.
> 
> Just as a question how did the project deal with patches?
> Should I wait till I get feedback for my first patches or should I send the
> next patches for libvirt?

It is usually a good idea to send in a patchset and then wait for feedback just
to avoid making the same mistakes over and over again. There might be a little
bit of a learning curve to some of those things.

But apart from this, well done!

Best,
-Michael

> 
> Regards Jonatan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]