From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Libvirt and ebtables [2]
Date: Tue, 29 Mar 2016 14:15:08 +0100 [thread overview]
Message-ID: <1459257308.30749.183.camel@ipfire.org> (raw)
In-Reply-To: <1458900796-18984-1-git-send-email-jonatan.schlag@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
Hi,
apologies for not reviewing this earlier...
This looks good. I merged the patches. You can commit things like these in just
one commit. Especially adding the patch file and applying that should be one
commit. Just as a hint for the future.
Merged.
Best,
-Michael
On Fri, 2016-03-25 at 11:13 +0100, Jonatan Schlag wrote:
> Hi,
> this is the new patch series for ebtables. Now the binaries are installed into
> /usr/sbin (libvirt should find them there).
> I tried to achieve this with more instructions for make install (make install
> LIBDIR=/usr/lib MANDIR=/usr/share/man SBINDIR=/usr/sbin) but this work only
> partially. The binaries were still installed into /usr/local/sbin.
> To avoid this definitely I create a patch for the Makefile of ebtables and
> now nothing is installed into /usr/local.
> The first patch creates the patch file for ebtables the second contain the
> necessary change for the rootfile and the lfs file.
> I hope this solution is ok.
>
> Regards Jonatan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-29 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 10:13 Jonatan Schlag
2016-03-25 10:13 ` [PATCH 1/2] add a patch for ebtables (to fix the problem with usr local) Jonatan Schlag
2016-03-25 10:13 ` [PATCH 2/2] build ebtables with the new patch (nothing go into " Jonatan Schlag
2016-03-25 16:13 ` [PATCH 3/3] bump ebtables version number Jonatan Schlag
2016-03-29 13:15 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459257308.30749.183.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox