From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ipfire-theme/functions.pl: Load $extrahead after jQuery
Date: Sun, 28 Nov 2021 12:00:15 +0000 [thread overview]
Message-ID: <145C2698-6DF2-41E1-B6C6-5F5A30300426@ipfire.org> (raw)
In-Reply-To: <20211127191043.1279-1-hofmann@leo-andres.de>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 27 Nov 2021, at 19:10, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrote:
>
> This ensures that jQuery is also available for custom javascript
> added to the HTML <head> with $extrahead.
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/html/themes/ipfire/include/functions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl
> index 18931428e..54f8966d5 100644
> --- a/html/html/themes/ipfire/include/functions.pl
> +++ b/html/html/themes/ipfire/include/functions.pl
> @@ -120,12 +120,12 @@ print <<END;
> <html>
> <head>
> <title>$headline - $title</title>
> - $extrahead
> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
> <link rel="shortcut icon" href="/favicon.ico" />
> <script type="text/javascript" src="/include/jquery.js"></script>
> <script src="/include/rrdimage.js"></script>
>
> + $extrahead
> <script type="text/javascript">
> function swapVisibility(id) {
> \$('#' + id).toggle();
> --
> 2.27.0.windows.1
>
prev parent reply other threads:[~2021-11-28 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 19:10 Leo-Andres Hofmann
2021-11-28 12:00 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145C2698-6DF2-41E1-B6C6-5F5A30300426@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox