* Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.
[not found] <1461930782-25457-1-git-send-email-stefan.schantl@ipfire.org>
@ 2016-04-29 12:06 ` Michael Tremer
2016-04-29 12:32 ` Stefan Schantl
0 siblings, 1 reply; 5+ messages in thread
From: Michael Tremer @ 2016-04-29 12:06 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
Hi,
you are introducing whitespace errors there by using spaces instead of tabs.
-Michael
P.S. You can also send this patch to both mailing lists at the same time by
using Cc.
On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
> A returned error code 702 when using Zoneedit as provider now raise
> a request error with an corresponding message instead of a simple
> InternalServerError exception.
>
> This will help to clarify and debug update problems.
>
> Fixes #11042.
>
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/ddns/providers.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 3845193..dbe9261 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
> elif output.startswith("<ERROR CODE=\"704\""):
> raise DDNSRequestError(_("No valid FQDN was
> given."))
> elif output.startswith("<ERROR CODE=\"702\""):
> - raise DDNSInternalServerError
> + raise DDNSRequestError(_("Too frequent update
> requests have been sent."))
>
> # If we got here, some other update error happened.
> raise DDNSUpdateError
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.
2016-04-29 12:06 ` [PATCH] Zoneedit: Provide better error message on error 702 responses Michael Tremer
@ 2016-04-29 12:32 ` Stefan Schantl
2016-04-29 12:35 ` [PATCHv2] " Stefan Schantl
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Schantl @ 2016-04-29 12:32 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
Thanks for reviewing,
I really don't know why this happened. It seems my vim is miss-
configured and translates tabs into spaces. When using nano as
editor everything works fine....
I'll fix this issue and send a new patch.
-Stefan
> Hi,
>
> you are introducing whitespace errors there by using spaces instead
> of tabs.
>
> -Michael
>
> P.S. You can also send this patch to both mailing lists at the same
> time by
> using Cc.
>
> On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
> >
> > A returned error code 702 when using Zoneedit as provider now raise
> > a request error with an corresponding message instead of a simple
> > InternalServerError exception.
> >
> > This will help to clarify and debug update problems.
> >
> > Fixes #11042.
> >
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> > src/ddns/providers.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> > index 3845193..dbe9261 100644
> > --- a/src/ddns/providers.py
> > +++ b/src/ddns/providers.py
> > @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
> > elif output.startswith("<ERROR CODE=\"704\""):
> > raise DDNSRequestError(_("No valid FQDN
> > was
> > given."))
> > elif output.startswith("<ERROR CODE=\"702\""):
> > - raise DDNSInternalServerError
> > + raise DDNSRequestError(_("Too frequent
> > update
> > requests have been sent."))
> >
> > # If we got here, some other update error
> > happened.
> > raise DDNSUpdateError
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCHv2] Zoneedit: Provide better error message on error 702 responses.
2016-04-29 12:32 ` Stefan Schantl
@ 2016-04-29 12:35 ` Stefan Schantl
2016-04-29 12:36 ` Michael Tremer
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Schantl @ 2016-04-29 12:35 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
A returned error code 702 when using Zoneedit as provider now raise
a request error with an corresponding message instead of a simple
InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
src/ddns/providers.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 3845193..c653aa5 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
elif output.startswith("<ERROR CODE=\"704\""):
raise DDNSRequestError(_("No valid FQDN was given."))
elif output.startswith("<ERROR CODE=\"702\""):
- raise DDNSInternalServerError
+ raise DDNSRequestError(_("Too frequent update requests have been sent."))
# If we got here, some other update error happened.
raise DDNSUpdateError
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCHv2] Zoneedit: Provide better error message on error 702 responses.
2016-04-29 12:35 ` [PATCHv2] " Stefan Schantl
@ 2016-04-29 12:36 ` Michael Tremer
0 siblings, 0 replies; 5+ messages in thread
From: Michael Tremer @ 2016-04-29 12:36 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
ACK
On Fri, 2016-04-29 at 14:35 +0200, Stefan Schantl wrote:
> A returned error code 702 when using Zoneedit as provider now raise
> a request error with an corresponding message instead of a simple
> InternalServerError exception.
>
> This will help to clarify and debug update problems.
>
> Fixes #11042.
>
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/ddns/providers.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 3845193..c653aa5 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
> elif output.startswith("<ERROR CODE=\"704\""):
> raise DDNSRequestError(_("No valid FQDN was
> given."))
> elif output.startswith("<ERROR CODE=\"702\""):
> - raise DDNSInternalServerError
> + raise DDNSRequestError(_("Too frequent update
> requests have been sent."))
>
> # If we got here, some other update error happened.
> raise DDNSUpdateError
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Zoneedit: Provide better error message on error 702 responses.
@ 2016-04-29 11:50 Stefan Schantl
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Schantl @ 2016-04-29 11:50 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
A returned error code 702 when using Zoneedit as provider now raise
a request error with an corresponding message instead of a simple
InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
src/ddns/providers.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 3845193..dbe9261 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
elif output.startswith("<ERROR CODE=\"704\""):
raise DDNSRequestError(_("No valid FQDN was given."))
elif output.startswith("<ERROR CODE=\"702\""):
- raise DDNSInternalServerError
+ raise DDNSRequestError(_("Too frequent update requests have been sent."))
# If we got here, some other update error happened.
raise DDNSUpdateError
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-29 12:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1461930782-25457-1-git-send-email-stefan.schantl@ipfire.org>
2016-04-29 12:06 ` [PATCH] Zoneedit: Provide better error message on error 702 responses Michael Tremer
2016-04-29 12:32 ` Stefan Schantl
2016-04-29 12:35 ` [PATCHv2] " Stefan Schantl
2016-04-29 12:36 ` Michael Tremer
2016-04-29 11:50 [PATCH] " Stefan Schantl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox