Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.

Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

Hi,

you are introducing whitespace errors there by using spaces instead of tabs.

-Michael

P.S. You can also send this patch to both mailing lists at the same time by
using Cc.

On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
> A returned error code 702 when using Zoneedit as provider now raise
> a request error with an corresponding message instead of a simple
> InternalServerError exception.
> 
> This will help to clarify and debug update problems.
> 
> Fixes #11042.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  src/ddns/providers.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 3845193..dbe9261 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
>  		elif output.startswith("<ERROR CODE=\"704\""):
>  			raise DDNSRequestError(_("No valid FQDN was
> given.")) 
>  		elif output.startswith("<ERROR CODE=\"702\""):
> -			raise DDNSInternalServerError
> +                        raise DDNSRequestError(_("Too frequent update
> requests have been sent."))
>  
>  		# If we got here, some other update error happened.
>  		raise DDNSUpdateError

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

Thanks for reviewing,

I really don't know why this happened. It seems my vim is miss-
configured and translates tabs into spaces. When using nano as
editor everything works fine....

I'll fix this issue and send a new patch.

-Stefan
> Hi,
> 
> you are introducing whitespace errors there by using spaces instead
> of tabs.
> 
> -Michael
> 
> P.S. You can also send this patch to both mailing lists at the same
> time by
> using Cc.
> 
> On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
> > 
> > A returned error code 702 when using Zoneedit as provider now raise
> > a request error with an corresponding message instead of a simple
> > InternalServerError exception.
> > 
> > This will help to clarify and debug update problems.
> > 
> > Fixes #11042.
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> >  src/ddns/providers.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> > index 3845193..dbe9261 100644
> > --- a/src/ddns/providers.py
> > +++ b/src/ddns/providers.py
> > @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
> >  		elif output.startswith("<ERROR CODE=\"704\""):
> >  			raise DDNSRequestError(_("No valid FQDN
> > was
> > given.")) 
> >  		elif output.startswith("<ERROR CODE=\"702\""):
> > -			raise DDNSInternalServerError
> > +                        raise DDNSRequestError(_("Too frequent
> > update
> > requests have been sent."))
> >  
> >  		# If we got here, some other update error
> > happened.
> >  		raise DDNSUpdateError

[PATCHv2] Zoneedit: Provide better error message on error 702 responses.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

A returned error code 702 when using Zoneedit as provider now raise
a request error with an corresponding message instead of a simple
InternalServerError exception.

This will help to clarify and debug update problems.

Fixes #11042.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 src/ddns/providers.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 3845193..c653aa5 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
 		elif output.startswith("<ERROR CODE=\"704\""):
 			raise DDNSRequestError(_("No valid FQDN was given.")) 
 		elif output.startswith("<ERROR CODE=\"702\""):
-			raise DDNSInternalServerError
+			raise DDNSRequestError(_("Too frequent update requests have been sent."))
 
 		# If we got here, some other update error happened.
 		raise DDNSUpdateError
-- 
2.5.5

Re: [PATCHv2] Zoneedit: Provide better error message on error 702 responses.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

ACK

On Fri, 2016-04-29 at 14:35 +0200, Stefan Schantl wrote:
> A returned error code 702 when using Zoneedit as provider now raise
> a request error with an corresponding message instead of a simple
> InternalServerError exception.
> 
> This will help to clarify and debug update problems.
> 
> Fixes #11042.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  src/ddns/providers.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 3845193..c653aa5 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
>  		elif output.startswith("<ERROR CODE=\"704\""):
>  			raise DDNSRequestError(_("No valid FQDN was
> given.")) 
>  		elif output.startswith("<ERROR CODE=\"702\""):
> -			raise DDNSInternalServerError
> +			raise DDNSRequestError(_("Too frequent update
> requests have been sent."))
>  
>  		# If we got here, some other update error happened.
>  		raise DDNSUpdateError

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]