public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] igmpproxy: fix build fail and move binary to /usr/sbin
Date: Wed, 01 Jun 2016 21:55:47 +0100	[thread overview]
Message-ID: <1464814547.19435.324.camel@ipfire.org> (raw)
In-Reply-To: <1464759232-30382-1-git-send-email-marcel.lorenz@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

Hi,

does the configure script not support --prefix=/usr here?

This would make moving the binary unnecessary and is a cleaner approach.

Best,
-Michael

On Wed, 2016-06-01 at 07:33 +0200, Marcel Lorenz wrote:
> Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
> ---
>  config/rootfiles/packages/igmpproxy | 2 +-
>  lfs/igmpproxy                       | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/config/rootfiles/packages/igmpproxy
> b/config/rootfiles/packages/igmpproxy
> index 1b34521..dda6dce 100644
> --- a/config/rootfiles/packages/igmpproxy
> +++ b/config/rootfiles/packages/igmpproxy
> @@ -1,5 +1,5 @@
>  etc/igmpproxy.conf
> -usr/local/sbin/igmpproxy
>  #usr/local/share/man/man5/igmpproxy.conf.5
>  #usr/local/share/man/man8/igmpproxy.8
> +usr/sbin/igmpproxy
>  var/ipfire/backup/addons/includes/igmpproxy
> diff --git a/lfs/igmpproxy b/lfs/igmpproxy
> index fb1426f..256022c 100644
> --- a/lfs/igmpproxy
> +++ b/lfs/igmpproxy
> @@ -82,11 +82,12 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  	cd $(DIR_APP) && patch -Np1  < $(DIR_SRC)/src/patches/igmpproxy-003-
> Restrict-igmp-reports-for-downstream-interfaces-wrt-.patch
>  	cd $(DIR_APP) && patch -Np1  < $(DIR_SRC)/src/patches/igmpproxy-004-
> Restrict-igmp-reports-forwarding-to-upstream-interfa.patch
>  	cd $(DIR_APP) && patch -Np1  < $(DIR_SRC)/src/patches/igmpproxy-100-
> use-monotic-clock-instead-of-time-of-day.patch
> -	cd $(DIR_APP) && autoreconf
> +	cd $(DIR_APP) && aclocal && automake --add-missing && autoreconf
>  	cd $(DIR_APP) && ./configure --sysconfdir=/etc
>  	cd $(DIR_APP) && make $(MAKETUNING)
>  	cd $(DIR_APP) && make install
>  	install -v -m 644 $(DIR_SRC)/config/backup/includes/igmpproxy \
>  	                 /var/ipfire/backup/addons/includes/igmpproxy
> +	mv -vf /usr/local/sbin/igmpproxy /usr/sbin/
>  	@rm -rf $(DIR_APP)
>  	@$(POSTBUILD)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-06-01 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  5:33 Marcel Lorenz
2016-06-01 20:55 ` Michael Tremer [this message]
2016-06-02  8:08   ` Marcel Lorenz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464814547.19435.324.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox