Re: [PATCH] openvmtools: add release file

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2538 bytes --]

Hi,

On Sun, 2016-06-05 at 07:50 +0200, Marcel Lorenz wrote:
> This patch add a simple release file to disable log spam
> The user never see the text in this file
> 
> Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
> ---
>  config/openvmtools/release            | 3 +++
>  config/rootfiles/packages/openvmtools | 1 +
>  lfs/openvmtools                       | 3 ++-
>  3 files changed, 6 insertions(+), 1 deletion(-)
>  create mode 100644 config/openvmtools/release
> 
> diff --git a/config/openvmtools/release b/config/openvmtools/release
> new file mode 100644
> index 0000000..ef16ac1
> --- /dev/null
> +++ b/config/openvmtools/release
> @@ -0,0 +1,3 @@
> +COMMENT="This is needed for open-vm-tools"
> +DISTRIB_ID="IPFire"
> +DISTRIB_RELEASE="IPFire"

This is no better. The LSB does however not specify the content of this file,
but there are some other commands that parse it and their output is specified:

  http://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generi
c/lsbrelease.html

So release should contain the release number of the distribution. "IPFire" is
not our release version.

> diff --git a/config/rootfiles/packages/openvmtools
> b/config/rootfiles/packages/openvmtools
> index caeb568..3529272 100644
> --- a/config/rootfiles/packages/openvmtools
> +++ b/config/rootfiles/packages/openvmtools
> @@ -2,6 +2,7 @@ etc/rc.d/init.d/openvmtools
>  etc/rc.d/rc0.d/K01openvmtools
>  etc/rc.d/rc3.d/S60openvmtools
>  etc/rc.d/rc6.d/K01openvmtools
> +etc/release
>  etc/vmware-tools
>  etc/vmware-tools/guestproxy-ssl.conf
>  etc/vmware-tools/poweroff-vm-default
> diff --git a/lfs/openvmtools b/lfs/openvmtools
> index 044994d..cf64203 100644
> --- a/lfs/openvmtools
> +++ b/lfs/openvmtools
> @@ -33,7 +33,7 @@ DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  SUP_ARCH   = x86_64 i586
>  PROG       = openvmtools
> -PAK_VER    = 2
> +PAK_VER    = 3
>  
>  DEPS       = ""
>  
> @@ -97,5 +97,6 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  	ln -sf ../init.d/openvmtools /etc/rc.d/rc0.d/K01openvmtools
>  	ln -sf ../init.d/openvmtools /etc/rc.d/rc6.d/K01openvmtools
>  	rm -rvf /usr/etc/pam.d /usr/share/openvmtools
> +	cp -fv $(DIR_SRC)/config/openvmtools/release /etc/

Please specify the exact destination. It makes the builds less messy.

>  	@rm -rf $(DIR_APP)
>  	@$(POSTBUILD)

-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]