From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] openvmtools: add release file
Date: Mon, 06 Jun 2016 22:10:32 +0100
Message-ID: <1465247432.24121.103.camel@ipfire.org>
In-Reply-To: <1465105854-8642-1-git-send-email-marcel.lorenz@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9066176418576488266=="
List-Id: <development.lists.ipfire.org>

--===============9066176418576488266==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2016-06-05 at 07:50 +0200, Marcel Lorenz wrote:
> This patch add a simple release file to disable log spam
> The user never see the text in this file
>=20
> Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
> ---
> =C2=A0config/openvmtools/release=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 3 +++
> =C2=A0config/rootfiles/packages/openvmtools | 1 +
> =C2=A0lfs/openvmtools=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0| 3 ++-
> =C2=A03 files changed, 6 insertions(+), 1 deletion(-)
> =C2=A0create mode 100644 config/openvmtools/release
>=20
> diff --git a/config/openvmtools/release b/config/openvmtools/release
> new file mode 100644
> index 0000000..ef16ac1
> --- /dev/null
> +++ b/config/openvmtools/release
> @@ -0,0 +1,3 @@
> +COMMENT=3D"This is needed for open-vm-tools"
> +DISTRIB_ID=3D"IPFire"
> +DISTRIB_RELEASE=3D"IPFire"

This is no better. The LSB does however not specify the content of this file,
but there are some other commands that parse it and their output is specified:

=C2=A0=C2=A0http://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LS=
B-Core-generi
c/lsbrelease.html

So release should contain the release number of the distribution. "IPFire" is
not our release version.

> diff --git a/config/rootfiles/packages/openvmtools
> b/config/rootfiles/packages/openvmtools
> index caeb568..3529272 100644
> --- a/config/rootfiles/packages/openvmtools
> +++ b/config/rootfiles/packages/openvmtools
> @@ -2,6 +2,7 @@ etc/rc.d/init.d/openvmtools
> =C2=A0etc/rc.d/rc0.d/K01openvmtools
> =C2=A0etc/rc.d/rc3.d/S60openvmtools
> =C2=A0etc/rc.d/rc6.d/K01openvmtools
> +etc/release
> =C2=A0etc/vmware-tools
> =C2=A0etc/vmware-tools/guestproxy-ssl.conf
> =C2=A0etc/vmware-tools/poweroff-vm-default
> diff --git a/lfs/openvmtools b/lfs/openvmtools
> index 044994d..cf64203 100644
> --- a/lfs/openvmtools
> +++ b/lfs/openvmtools
> @@ -33,7 +33,7 @@ DIR_APP=C2=A0=C2=A0=C2=A0=C2=A0=3D $(DIR_SRC)/$(THISAPP)
> =C2=A0TARGET=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D $(DIR_INFO)/$(THISAPP)
> =C2=A0SUP_ARCH=C2=A0=C2=A0=C2=A0=3D x86_64 i586
> =C2=A0PROG=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D openvmtools
> -PAK_VER=C2=A0=C2=A0=C2=A0=C2=A0=3D 2
> +PAK_VER=C2=A0=C2=A0=C2=A0=C2=A0=3D 3
> =C2=A0
> =C2=A0DEPS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D ""
> =C2=A0
> @@ -97,5 +97,6 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> =C2=A0	ln -sf ../init.d/openvmtools /etc/rc.d/rc0.d/K01openvmtools
> =C2=A0	ln -sf ../init.d/openvmtools /etc/rc.d/rc6.d/K01openvmtools
> =C2=A0	rm -rvf /usr/etc/pam.d /usr/share/openvmtools
> +	cp -fv $(DIR_SRC)/config/openvmtools/release /etc/

Please specify the exact destination. It makes the builds less messy.

> =C2=A0	@rm -rf $(DIR_APP)
> =C2=A0	@$(POSTBUILD)

-Michael

--===============9066176418576488266==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlhWZWJJQUFvSkVJQjU4UDl2a0FrSG9SQVAvUjVSeGtUTmlYZytJbmFTNW1CaXpFN3QK
ajFhWUhZK1RkOWhyNjM4Nm91bFNpclFzYnNpT0NBMHA4NkFIcEdNM3ZNS0I3Z252QSt3eklScXhv
cEQvSWN6OApXNFpWVTExRTdsSWkxTlRrSjlHUnFxVjlXVXZERG1KaVRGWlNWYWpBaXpxUGw3S1li
Uko5aTFhM2xpM0ZBd2w0CjdVVGZhRlZIZlZGVWdGU3BrcW83a01UMnlGVXdsZ3pkZmNLUlg4RWg0
WmNZS1JMRVN2dnFRNU9sa2hvc1U2V08KSWg1RVMwL2FpZTFJeFdhSnRwNkpDK0hLaTFOUkc1OHZB
N3lYM2NzRUUxaWhPYk03VzJpSXlaS0dVOE1VZ2tIVApvT2lNcExOTGw4ckxUMXE3SC9iNjdmTWtq
SmhrZ3dpT09JVkFKelFkNXhJR0pjSWhTayt4dW8rVmphY3Z4UnlGClFnWTRLR0xiZWJEK1NoVjN1
YkxwUm5GejBZQ0RxQVNTNjNOc1BwRDlPNGRTWHMyRnhpM0xmRUxyY3BLeUxkNGcKUjFySUpMWG1m
c1JBWXQ3Qm12L1ZZRG1JbjlhOFhubUxVejROTS9EaVJUaEd0WHNkVjliQlFHSDVtZDFadFBJWApJ
NFZDNy84UVZISzFRYnJGdlBlZ0RwNDBQL0VnZFlCcEZrcDFtT25ueiszQWQ3MkJtTFB3Z1pTb2dj
Yi9kTUk1CjVTdDloaFkwM2Z5dWpjdnIxYXh2QWJnTTZTV1ROWk85QU5JNC83VnRvb1F0RG5xSVE5
SUgrL3V6dmZrQmpwMnEKYUhzQ2RUVGgwVURmdmtiOUtKSjBlWkxjd3FiVVhBSUV1RVpwSEE2Mjlq
S004eTdxSmp5NGRyMjV1UnFLQkJtawp3UWx5TmZ6dVhWWXdUaFV3U2QrMAo9aDlZWAotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============9066176418576488266==--