public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Fix in libvirt install.sh
Date: Thu, 14 Jul 2016 23:15:11 +0100	[thread overview]
Message-ID: <1468534511.2710.118.camel@ipfire.org> (raw)
In-Reply-To: <1468524782-666-1-git-send-email-jonatan.schlag@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Hi,

the same thing is happening in the uninstall.sh script where the service should
be stopped before being removed from disk.

-Michael

On Thu, 2016-07-14 at 21:33 +0200, Jonatan Schlag wrote:
> The libvirt daemon was not started after installation because the
> initscritp is named 'libvirtd' not like the package 'libvirt'.
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  lfs/libvirt                 | 2 +-
>  src/paks/libvirt/install.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/libvirt b/lfs/libvirt
> index 5af28cb..6768a72 100644
> --- a/lfs/libvirt
> +++ b/lfs/libvirt
> @@ -33,7 +33,7 @@ DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  SUP_ARCH   = i586 x86_64
>  PROG       = libvirt
> -PAK_VER    = 3
> +PAK_VER    = 4
>  
>  DEPS       = "libpciaccess libyajl ncat qemu"
>  
> diff --git a/src/paks/libvirt/install.sh b/src/paks/libvirt/install.sh
> index 2009b0e..c97a18d 100644
> --- a/src/paks/libvirt/install.sh
> +++ b/src/paks/libvirt/install.sh
> @@ -29,7 +29,7 @@ getent passwd libvirt-remote >/dev/null || \
>  useradd -m -g libvirt-remote -s /bin/bash "libvirt-remote"
>  
>  extract_files
> -start_service --delay 300 --background ${NAME}
> +start_service --delay 300 --background libvirtd
>  ln -svf /etc/init.d/libvirtd /etc/rc.d/rc0.d/K20libvirtd
>  ln -svf /etc/init.d/libvirtd /etc/rc.d/rc3.d/S70libvirtd
>  ln -svf /etc/init.d/libvirtd /etc/rc.d/rc6.d/K20libvirtd

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2016-07-14 22:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 19:33 Jonatan Schlag
2016-07-14 22:15 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468534511.2710.118.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox