Re: [PATCH] cifs-utils: new package cifs-utils 6.6

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2368 bytes --]

On Wed, 2016-09-07 at 12:23 +0000, Alexander Marx wrote:
> This package is needed by sssd.
> 
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> ---
>  cifs-utils/cifs-utils.nm | 48
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 cifs-utils/cifs-utils.nm
> 
> diff --git a/cifs-utils/cifs-utils.nm b/cifs-utils/cifs-utils.nm
> new file mode 100644
> index 0000000..0c68daf
> --- /dev/null
> +++ b/cifs-utils/cifs-utils.nm
> @@ -0,0 +1,48 @@
> +#############################################################################
> ##
> +# IPFire.org    - An Open Source Firewall
> Solution                            #
> +# Copyright (C) - IPFire Development Team <info(a)ipfire.org>                  
>  #
> +#############################################################################
> ##
> +
> +name       = cifs-utils
> +version    = 6.6
> +release    = 1
> +
> +groups     = System/Tools
> +url        = https://wiki.samba.org/index.php/LinuxCIFS_utils
> +license    = GNU GENERAL PUBLIC LICENSE

GPL is enough.

> +summary    = A utility for the Common Internet File System
> +
> +description
> +	This package of tools is called cifs-utils.
> +	Although not really part of Samba proper, these tools were originally
> part of the Samba package.
> +	For several reasons, shipping these tools as part of Samba was
> problematic and it was deemed better to split them off into their own package.
> +end
> +
> +source_dl  = http://download.samba.org/pub/linux-cifs/cifs-utils/
> +sources    = %{thisapp}.tar.bz2
> +
> +build
> +	requires
> +
> +	end
> +
> +	configure_options += \

This line and the block above are totally unnecessary.

> +
> +	test
> +		make check
> +	end
> +end
> +
> +packages
> +	package %{name}
> +		groups += Base Build
> +	end

These groups will cause that this package is always installed in the build
environment (which is not needed) and in the base system (which is not needed
either). It will be pulled in automatically by any packages that link against
it.

> +
> +	package %{name}-devel
> +		template DEVEL
> +	end
> +
> +	package %{name}-debuginfo
> +		template DEBUGINFO
> +	end
> +end

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]