From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Marx <alexander.marx@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] BUG11177: pppoe password not required anymore
Date: Thu, 08 Sep 2016 08:36:58 +0200
Message-ID: <1473316618-18264-1-git-send-email-alexander.marx@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3920979617757810230=="
List-Id: <development.lists.ipfire.org>

--===============3920979617757810230==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

fixes: #11177

There are providers which do not use passwords anymore.
For this reason the password field is no longer mandatory.

Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
---
 html/cgi-bin/pppsetup.cgi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
index 36d0ced..4b45ee5 100644
--- a/html/cgi-bin/pppsetup.cgi
+++ b/html/cgi-bin/pppsetup.cgi
@@ -103,10 +103,7 @@ elsif ($pppsettings{'ACTION'} eq $Lang::tr{'save'})
                 if ($pppsettings{'USERNAME'} eq '') {
                         $errormessage =3D $Lang::tr{'username not set'};
                         goto ERROR; }
-                if ($pppsettings{'PASSWORD'} eq '') {
-                        $errormessage =3D $Lang::tr{'password not set'};
-                        goto ERROR; }
-        }
+		}
=20
         if ($pppsettings{'TIMEOUT'} eq '') {
                 $errormessage =3D $Lang::tr{'idle timeout not set'};
@@ -927,7 +924,7 @@ print <<END
 <tr>
         <td width=3D'25%'>$Lang::tr{'username'}&nbsp;<img src=3D'/blob.gif' =
alt=3D'*' /></td>
         <td width=3D'25%'><input type=3D'text' name=3D'USERNAME' value=3D'$p=
ppsettings{'USERNAME'}' /></td>
-        <td width=3D'25%'>$Lang::tr{'password'}&nbsp;<img src=3D'/blob.gif' =
alt=3D'*' /></td>
+        <td width=3D'25%'>$Lang::tr{'password'}&nbsp;</td>
         <td width=3D'25%'><input type=3D'password' name=3D'PASSWORD' value=
=3D'$pppsettings{'PASSWORD'}' /></td>
 </tr>
 <tr>
--=20
2.7.4


--===============3920979617757810230==--