Re: [PATCH 1/2] ddns: Import patch for schokokeks.org support.

public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed

* Re: [PATCH 1/2] ddns: Import patch for schokokeks.org support.
       [not found] <1475225814-5754-1-git-send-email-stefan.schantl@ipfire.org>
@ 2016-10-01 19:59 ` Michael Tremer
  2016-10-28 13:48   ` [PATCHv2 1/2] ddns: Import patches " Stefan Schantl
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Tremer @ 2016-10-01 19:59 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 3217 bytes --]

Hi,

I did not see this patch going through the normal mailing list process.

However, I have a comment that I will post here instead.

On Fri, 2016-09-30 at 10:56 +0200, Stefan Schantl wrote:
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  lfs/ddns                                           |  2 +
>  .../ddns-0001-New-provider-Schokokeks.org.patch    | 47
> ++++++++++++++++++++++
>  2 files changed, 49 insertions(+)
>  create mode 100644 src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> 
> diff --git a/lfs/ddns b/lfs/ddns
> index 422f8e3..90c70c6 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -71,6 +71,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  	@$(PREBUILD)
>  	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
>  
> +	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-0001-New-
> provider-Schokokeks.org.patch
> +
>  	cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
>  	cd $(DIR_APP) && ./configure \
>  		--prefix=/usr \
> diff --git a/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> new file mode 100644
> index 0000000..be123a5
> --- /dev/null
> +++ b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> @@ -0,0 +1,47 @@
> +From 521c9d90f4e879ef3d9e1590f29e27990011ae46 Mon Sep 17 00:00:00 2001
> +From: Steffen Peters <sauron99(a)gmx.de>
> +Date: Mon, 4 Jul 2016 22:14:10 +0200
> +Subject: [PATCH 185/185] New provider: Schokokeks.org
> +
> +Signed-off-by: Steffen Peters <sauron99(a)gmx.de>
> +Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +---
> + README                |  1 +
> + src/ddns/providers.py | 12 ++++++++++++
> + 2 files changed, 13 insertions(+)
> +
> +diff --git a/README b/README
> +index d8027a4..cedbf21 100644
> +--- a/README
> ++++ b/README
> +@@ -75,6 +75,7 @@ SUPPORTED PROVIDERS:
> + 	opendns.com
> + 	ovh.com
> + 	regfish.com
> ++	schokokeks.org
> + 	selfhost.de
> + 	spdns.org
> + 	strato.com
> +diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> +index 6b25cb6..c482dad 100644
> +--- a/src/ddns/providers.py
> ++++ b/src/ddns/providers.py
> +@@ -1687,3 +1687,15 @@ class DDNSProviderZZZZ(DDNSProvider):
> + 
> + 		# If we got here, some other update error happened.
> + 		raise DDNSUpdateError
> ++
> ++class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
> ++       handle    = "schokokeks.org"
> ++       name      = "Schokokeks"
> ++       website   = "http://www.schokokeks.org/"
> ++       protocols = ("ipv4",)
> ++
> ++       # Information about the format of the request is to be found
> ++       # https://wiki.schokokeks.org/DynDNS
> ++
> ++       url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>;"
> ++

This URL is clearly malformed and therefore the patch should not have been
accepted. <ipaddr> is just a placeholder here and luckily everything after the ?
is stripped off and replaced by the actual arguments. But that is still stuff
that I do not want to see here.

Best,
-Michael

> +-- 
> +2.7.4
> +

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCHv2 1/2] ddns: Import patches for schokokeks.org support.
  2016-10-01 19:59 ` [PATCH 1/2] ddns: Import patch for schokokeks.org support Michael Tremer
@ 2016-10-28 13:48   ` Stefan Schantl
  2016-10-28 13:48     ` [PATCHv2 2/2] Add DDNS to core 107 Stefan Schantl
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Schantl @ 2016-10-28 13:48 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 5064 bytes --]

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 lfs/ddns                                           |  3 ++
 .../ddns-0001-New-provider-Schokokeks.org.patch    | 47 ++++++++++++++++++
 ...2-Schokokeks.org-Fix-malformed-update-URL.patch | 55 ++++++++++++++++++++++
 3 files changed, 105 insertions(+)
 create mode 100644 src/patches/ddns-0001-New-provider-Schokokeks.org.patch
 create mode 100644 src/patches/ddns-0002-Schokokeks.org-Fix-malformed-update-URL.patch

diff --git a/lfs/ddns b/lfs/ddns
index 422f8e3..3d7efa5 100644
--- a/lfs/ddns
+++ b/lfs/ddns
@@ -71,6 +71,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 	@$(PREBUILD)
 	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
 
+	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
+	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-0002-Schokokeks.org-Fix-malformed-update-URL.patch
+
 	cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
 	cd $(DIR_APP) && ./configure \
 		--prefix=/usr \
diff --git a/src/patches/ddns-0001-New-provider-Schokokeks.org.patch b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
new file mode 100644
index 0000000..be123a5
--- /dev/null
+++ b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
@@ -0,0 +1,47 @@
+From 521c9d90f4e879ef3d9e1590f29e27990011ae46 Mon Sep 17 00:00:00 2001
+From: Steffen Peters <sauron99(a)gmx.de>
+Date: Mon, 4 Jul 2016 22:14:10 +0200
+Subject: [PATCH 185/185] New provider: Schokokeks.org
+
+Signed-off-by: Steffen Peters <sauron99(a)gmx.de>
+Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
+---
+ README                |  1 +
+ src/ddns/providers.py | 12 ++++++++++++
+ 2 files changed, 13 insertions(+)
+
+diff --git a/README b/README
+index d8027a4..cedbf21 100644
+--- a/README
++++ b/README
+@@ -75,6 +75,7 @@ SUPPORTED PROVIDERS:
+ 	opendns.com
+ 	ovh.com
+ 	regfish.com
++	schokokeks.org
+ 	selfhost.de
+ 	spdns.org
+ 	strato.com
+diff --git a/src/ddns/providers.py b/src/ddns/providers.py
+index 6b25cb6..c482dad 100644
+--- a/src/ddns/providers.py
++++ b/src/ddns/providers.py
+@@ -1687,3 +1687,15 @@ class DDNSProviderZZZZ(DDNSProvider):
+ 
+ 		# If we got here, some other update error happened.
+ 		raise DDNSUpdateError
++
++class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
++       handle    = "schokokeks.org"
++       name      = "Schokokeks"
++       website   = "http://www.schokokeks.org/"
++       protocols = ("ipv4",)
++
++       # Information about the format of the request is to be found
++       # https://wiki.schokokeks.org/DynDNS
++
++       url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>"
++
+-- 
+2.7.4
+
diff --git a/src/patches/ddns-0002-Schokokeks.org-Fix-malformed-update-URL.patch b/src/patches/ddns-0002-Schokokeks.org-Fix-malformed-update-URL.patch
new file mode 100644
index 0000000..e00dcf6
--- /dev/null
+++ b/src/patches/ddns-0002-Schokokeks.org-Fix-malformed-update-URL.patch
@@ -0,0 +1,55 @@
+From f77e6bc92825d65e881d5dc7fc443139278c0d5f Mon Sep 17 00:00:00 2001
+From: Stefan Schantl <stefan.schantl(a)ipfire.org>
+Date: Fri, 28 Oct 2016 12:35:20 +0200
+Subject: [PATCH 3/3] Schockokeks.org: Fix malformed update URL.
+
+* Move Provider Class into correct alphabetical order.
+
+Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
+Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
+Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
+---
+ src/ddns/providers.py | 23 +++++++++++------------
+ 1 file changed, 11 insertions(+), 12 deletions(-)
+
+diff --git a/src/ddns/providers.py b/src/ddns/providers.py
+index c482dad..2c30d42 100644
+--- a/src/ddns/providers.py
++++ b/src/ddns/providers.py
+@@ -1424,6 +1424,17 @@ class DDNSProviderRegfish(DDNSProvider):
+ 		raise DDNSUpdateError
+ 
+ 
++class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
++	handle    = "schokokeks.org"
++	name      = "Schokokeks"
++	website   = "http://www.schokokeks.org/"
++	protocols = ("ipv4",)
++
++	# Information about the format of the request is to be found
++	# https://wiki.schokokeks.org/DynDNS
++	url = "https://dyndns.schokokeks.org/nic/update"
++
++
+ class DDNSProviderSelfhost(DDNSProtocolDynDNS2, DDNSProvider):
+ 	handle    = "selfhost.de"
+ 	name      = "Selfhost.de"
+@@ -1687,15 +1698,3 @@ class DDNSProviderZZZZ(DDNSProvider):
+ 
+ 		# If we got here, some other update error happened.
+ 		raise DDNSUpdateError
+-
+-class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
+-       handle    = "schokokeks.org"
+-       name      = "Schokokeks"
+-       website   = "http://www.schokokeks.org/"
+-       protocols = ("ipv4",)
+-
+-       # Information about the format of the request is to be found
+-       # https://wiki.schokokeks.org/DynDNS
+-
+-       url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>"
+-
+-- 
+2.7.4
+
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCHv2 2/2] Add DDNS to core 107.
  2016-10-28 13:48   ` [PATCHv2 1/2] ddns: Import patches " Stefan Schantl
@ 2016-10-28 13:48     ` Stefan Schantl
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Schantl @ 2016-10-28 13:48 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 config/rootfiles/core/107/filelists/ddns | 1 +
 1 file changed, 1 insertion(+)
 create mode 120000 config/rootfiles/core/107/filelists/ddns

diff --git a/config/rootfiles/core/107/filelists/ddns b/config/rootfiles/core/107/filelists/ddns
new file mode 120000
index 0000000..7395164
--- /dev/null
+++ b/config/rootfiles/core/107/filelists/ddns
@@ -0,0 +1 @@
+../../../common/ddns
\ No newline at end of file
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-28 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1475225814-5754-1-git-send-email-stefan.schantl@ipfire.org>
2016-10-01 19:59 ` [PATCH 1/2] ddns: Import patch for schokokeks.org support Michael Tremer
2016-10-28 13:48   ` [PATCHv2 1/2] ddns: Import patches " Stefan Schantl
2016-10-28 13:48     ` [PATCHv2 2/2] Add DDNS to core 107 Stefan Schantl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox