Re: [PATCH] Update libvirt to 2.4

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2476 bytes --]

Hi,

thanks for the patch.

I reviewed it and merged it with some smaller modifications:

* I fixed some grammar and typos in the commit message :)

* And I reset the release version back to 1. When ever version
  is increased, we reset release to 1 and only count it up
  if the package is changed without using a newer version from
  upstream. This is different than in IPFire 2.

I also sent an other commit which makes you maintainer of this
package. I hope you agree.

Best,
-Michael

On Sat, 2016-11-26 at 08:12 +0000, Jonatan Schlag wrote:
> This patch update libvirt to version 2.4 for changelog see:
> https://libvirt.org/news-2016.html
> 
> This patch also add some new configure switches.
> We build now only for qemu/kvm, the build for vmware an phyp
> are now disabled.
> And libvirt is now explicit build without SELinux.
> This change was necessary because of  the fact that
> a  build dependency of libvirt, require still SELinux
> and so libvirt is also linked against SELinux
> because it is available in the build environment.
> Till we get completely rid of SELinux we should use these switches.
> So we have a libvirt that does not require SELinux otherwise,
> we would have to release a version when we dropped SELinux completely,
> which would be stupid.
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  libvirt/libvirt.nm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt/libvirt.nm b/libvirt/libvirt.nm
> index fc15edf..b06c12b 100644
> --- a/libvirt/libvirt.nm
> +++ b/libvirt/libvirt.nm
> @@ -4,8 +4,8 @@
>  #############################################################################
> ##
>  
>  name       = libvirt
> -version    = 2.3.0
> -release    = 1
> +version    = 2.4.0
> +release    = 2
>  
>  maintainer = Ben Schweikert <ben.schweikert(a)ipfire.org>
>  groups     = Applications/Virtualization
> @@ -50,7 +50,9 @@ build
>  		--libexecdir=/usr/lib \
>  		--disable-static \
>  		--with-qemu \
> +		--without-vmware \
>  		--without-esx \
> +		--without-phyp \
>  		--without-hal \
>  		--without-lxc \
>  		--without-openvz \
> @@ -64,6 +66,9 @@ build
>  		--with-storage-disk \
>  		--with-avahi \
>  		--with-udev \
> +		--without-secdriver-selinux \
> +		--without-selinux \
> +		--without-selinux-mount \
>  		--with-libvirtd
>  end
>  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]