From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Update libvirt to 2.4
Date: Sat, 26 Nov 2016 12:32:35 +0000
Message-ID: <1480163555.13949.15.camel@ipfire.org>
In-Reply-To: <1480147974-3235-1-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1063866232814296946=="
List-Id: <development.lists.ipfire.org>

--===============1063866232814296946==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

thanks for the patch.

I reviewed it and merged it with some smaller modifications:

* I fixed some grammar and typos in the commit message :)

* And I reset the release version back to 1. When ever version
=C2=A0 is increased, we reset release to 1 and only count it up
=C2=A0 if the package is changed without using a newer version from
=C2=A0 upstream. This is different than in IPFire 2.

I also sent an other commit which makes you maintainer of this
package. I hope you agree.

Best,
-Michael

On Sat, 2016-11-26 at 08:12 +0000, Jonatan Schlag wrote:
> This patch update libvirt to version 2.4 for changelog see:
> https://libvirt.org/news-2016.html
>=20
> This patch also add some new configure switches.
> We build now only for qemu/kvm, the build for vmware an phyp
> are now disabled.
> And libvirt is now explicit build without SELinux.
> This change was necessary because of=C2=A0=C2=A0the fact that
> a=C2=A0=C2=A0build dependency of libvirt, require still SELinux
> and so libvirt is also linked against SELinux
> because it is available in the build environment.
> Till we get completely rid of SELinux we should use these switches.
> So we have a libvirt that does not require SELinux otherwise,
> we would have to release a version when we dropped SELinux completely,
> which would be stupid.
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> =C2=A0libvirt/libvirt.nm | 9 +++++++--
> =C2=A01 file changed, 7 insertions(+), 2 deletions(-)
>=20
> diff --git a/libvirt/libvirt.nm b/libvirt/libvirt.nm
> index fc15edf..b06c12b 100644
> --- a/libvirt/libvirt.nm
> +++ b/libvirt/libvirt.nm
> @@ -4,8 +4,8 @@
> =C2=A0#####################################################################=
########
> ##
> =C2=A0
> =C2=A0name=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D libvirt
> -version=C2=A0=C2=A0=C2=A0=C2=A0=3D 2.3.0
> -release=C2=A0=C2=A0=C2=A0=C2=A0=3D 1
> +version=C2=A0=C2=A0=C2=A0=C2=A0=3D 2.4.0
> +release=C2=A0=C2=A0=C2=A0=C2=A0=3D 2
> =C2=A0
> =C2=A0maintainer =3D Ben Schweikert <ben.schweikert(a)ipfire.org>
> =C2=A0groups=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D Applications/Virtualization
> @@ -50,7 +50,9 @@ build
> =C2=A0		--libexecdir=3D/usr/lib \
> =C2=A0		--disable-static \
> =C2=A0		--with-qemu \
> +		--without-vmware \
> =C2=A0		--without-esx \
> +		--without-phyp \
> =C2=A0		--without-hal \
> =C2=A0		--without-lxc \
> =C2=A0		--without-openvz \
> @@ -64,6 +66,9 @@ build
> =C2=A0		--with-storage-disk \
> =C2=A0		--with-avahi \
> =C2=A0		--with-udev \
> +		--without-secdriver-selinux \
> +		--without-selinux \
> +		--without-selinux-mount \
> =C2=A0		--with-libvirtd
> =C2=A0end
> =C2=A0

--===============1063866232814296946==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSllPWURqQUFvSkVJQjU4UDl2a0FrSEwxWVAvaXhLTmpiMXFPOUVqa04wVCsxeTNXbnIK
UHFBRkk0dEh1L3h6ZkU2UUxKSVUwd2w4aUhJMlFpV2ZxdlFybVprRjB6eUhvaWMrc3M4YVpGM1la
akN1OGQwdApGMktkY1hsV2NBWUpUTUxIU2F4NGIvSVRFSzVIN2k0S2lscWErQ1ZubDRIVTRPdGhY
aURvOERBOWczZC9od09mClZ6V2NWaUxBQWRpZlFjZEYxMURjbTVpTEd0Ykt2NzVTVXN2OGFCTFZY
TzJVNktLOGFWWGF0T1l3dXgwRDVnYysKV1djMTJqTzRBUVE4U3kzS2F2REVGdW9JY0ZzdTRvUElt
SWxIZmR2L29JY3V6YXZNQWMvU054ZDU0UEIxYVNvcwp0ajhqaG1aU3JDTldGSzNJQzR6TWFkNUJk
Zy9OSDB2eDROWE56bU9tVTV6bWlGNzZPVlJtOEFIUGI4eDZtbWJNCmgrajFnTFJHcmxDMUJFZUdB
WUUyYmpjaC83L1FMSlNMT2QzY3dPNW9iVUdjcklEU25zUzRVT1c0OEVqeHk5a3UKNS9vcGlpQ1pG
eHBpQ0toTzlrcGlGK0RtYndzNDBaUWhENVdwUmt3WktaL2lPSHFZS3FWRVpod01SRXBhL2tiNgoy
eEFmOEFUYktXa2w0M3ZQSXJDZERWcVdXWTZTWHFOMm01RXFRd2FFcE5MMFNKdGlWdm1iNXliNUVw
d1ZVblBZCmhWMThxYitYMmx5YjBldHJudG54QlpjVG5vWUpkN0FVV1AweGhkeWh5MmJjQXhWaXgr
SmljTlVkMUpPUWlPVlEKdE5JcXdWWVdCTTdRV2FwcGFTaGZEaDBHcEloNEZYS3BjQW1PMk9YZXJ0
T0ZHS3NPSUU3QjZHUFFKVVlXVXNZMQplRXBUcWViZzhXSHYrNStNTmdMTAo9Vk02dQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============1063866232814296946==--