Re: [PATCH] python-systemd: New package.

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2579 bytes --]

Hi,

looks good, but the package should be called python3-systemd which complies with
the naming of the other ones.

Isn't there a possible runtime dependency to a specific version of systemd
required?

On Thu, 2016-12-01 at 14:10 +0100, Stefan Schantl wrote:
> This package now contains the python bindings for systemd.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  python-systemd/python-systemd.nm | 60
> ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 python-systemd/python-systemd.nm
> 
> diff --git a/python-systemd/python-systemd.nm b/python-systemd/python-
> systemd.nm
> new file mode 100644
> index 0000000..a291874
> --- /dev/null
> +++ b/python-systemd/python-systemd.nm
> @@ -0,0 +1,60 @@
> +#############################################################################
> ##
> +# IPFire.org    - An Open Source Firewall
> Solution                            #
> +# Copyright (C) - IPFire Development Team <info(a)ipfire.org>                  
>  #
> +#############################################################################
> ##
> +
> +name       = python-systemd
> +version    = 232
> +release    = 1
> +
> +groups     = Development/Tools
> +url        = https://github.com/systemd/python-systemd
> +license    = LGPLv2+
> +summary    = Python module wrapping systemd functionality.
> +
> +description
> +	This package contains various Python modulse for a native access to
> +	the systemd facilities.
> +end
> +
> +source_dl  = https://github.com/systemd/python-systemd/archive/v%{version}.ta
> r.gz#/
> +
> +build
> +	requires
> +		python3-devel >= 3.4
> +		systemd-devel
> +	end
> +
> +	prepare_cmds
> +		sed -i 's/py\.test/pytest/' Makefile
> +	end
> +
> +	make_build_targets += \
> +		PYTHON=%{python3}
> +
> +	test
> +		# Disable testsuite, because pytest is required
> +		# which is currently not available.
> +		#make PYTHON=%{python3} check
> +	end
> +
> +	make_install_targets +=\
> +		PYTHON=%{python3}

There could be a space between += and \

> +
> +	install_cmds
> +		# Remove accidently installed files from testsuite.
> +		rm -rvf %{BUILDROOT}%{python3_sitearch}/systemd/test
> +	end
> +end

Accidentially?

> +
> +packages
> +	package %{name}
> +		obsoletes
> +			python3-systemd >= 221
> +		end
> +	end
> +
> +	package %{name}-debuginfo
> +		template DEBUGINFO
> +	end
> +end

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]