From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] python-systemd: New package.
Date: Thu, 01 Dec 2016 13:17:27 +0000
Message-ID: <1480598247.13949.108.camel@ipfire.org>
In-Reply-To: <1480597834-15622-1-git-send-email-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9048964312184818780=="
List-Id: <development.lists.ipfire.org>

--===============9048964312184818780==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

looks good, but the package should be called python3-systemd which complies w=
ith
the naming of the other ones.

Isn't there a possible runtime dependency to a specific version of systemd
required?

On Thu, 2016-12-01 at 14:10 +0100, Stefan Schantl wrote:
> This package now contains the python bindings for systemd.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> =C2=A0python-systemd/python-systemd.nm | 60
> ++++++++++++++++++++++++++++++++++++++++
> =C2=A01 file changed, 60 insertions(+)
> =C2=A0create mode 100644 python-systemd/python-systemd.nm
>=20
> diff --git a/python-systemd/python-systemd.nm b/python-systemd/python-
> systemd.nm
> new file mode 100644
> index 0000000..a291874
> --- /dev/null
> +++ b/python-systemd/python-systemd.nm
> @@ -0,0 +1,60 @@
> +##########################################################################=
###
> ##
> +# IPFire.org=C2=A0=C2=A0=C2=A0=C2=A0- An Open Source Firewall
> Solution=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0#
> +# Copyright (C) - IPFire Development Team <info(a)ipfire.org>=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0
> =C2=A0#
> +##########################################################################=
###
> ##
> +
> +name=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D python-systemd
> +version=C2=A0=C2=A0=C2=A0=C2=A0=3D 232
> +release=C2=A0=C2=A0=C2=A0=C2=A0=3D 1
> +
> +groups=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D Development/Tools
> +url=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D https://github.com/=
systemd/python-systemd
> +license=C2=A0=C2=A0=C2=A0=C2=A0=3D LGPLv2+
> +summary=C2=A0=C2=A0=C2=A0=C2=A0=3D Python module wrapping systemd function=
ality.
> +
> +description
> +	This package contains various Python modulse for a native access to
> +	the systemd facilities.
> +end
> +
> +source_dl=C2=A0=C2=A0=3D https://github.com/systemd/python-systemd/archive=
/v%{version}.ta
> r.gz#/
> +
> +build
> +	requires
> +		python3-devel >=3D 3.4
> +		systemd-devel
> +	end
> +
> +	prepare_cmds
> +		sed -i 's/py\.test/pytest/' Makefile
> +	end
> +
> +	make_build_targets +=3D \
> +		PYTHON=3D%{python3}
> +
> +	test
> +		# Disable testsuite, because pytest is required
> +		# which is currently not available.
> +		#make PYTHON=3D%{python3} check
> +	end
> +
> +	make_install_targets +=3D\
> +		PYTHON=3D%{python3}

There could be a space between +=3D and \

> +
> +	install_cmds
> +		# Remove accidently installed files from testsuite.
> +		rm -rvf %{BUILDROOT}%{python3_sitearch}/systemd/test
> +	end
> +end

Accidentially?

> +
> +packages
> +	package %{name}
> +		obsoletes
> +			python3-systemd >=3D 221
> +		end
> +	end
> +
> +	package %{name}-debuginfo
> +		template DEBUGINFO
> +	end
> +end

--===============9048964312184818780==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSllRQ0xuQUFvSkVJQjU4UDl2a0FrSFJOQVAvMzY4blo4RkE1RXJWUGxSL0ZYZklJVG8K
TGpIMTJXaDVkUlQrb2daZ0hxeTNCTExjVEZ2SFMwY3crVzRoYWpGL3hORjhuclpmaWZMRWFNOGM5
Tk1pRWdTVApmUnVrQUlXdDRiQWJSZURjeU1aN3lmQVFJTDBqd0hDb1kwS3dLaXpGVmpOV2Y4ZFRz
QTkrN1pMemtsSU1MNmpJClhQVEpLbFU3T2J4RVBBM1FMUmJBbldHUDVJa2YyQkRzSjFCUTZXZm4y
S1lCaklVeXcrSElkSFd4MXVBam9hdDQKRlVlTU1vV2s5cUd3a2szbzhKdUUyS3JJdWhkcCtnaEdH
WjJ3UzczL2lISDhFWE1PaCtaaUlNVFJIaGtjd1dobQovZi8vV0NzSnBSMzFSNU10T3JKUFFVTkRt
UEtKMjh0YUw2OGY5N3dNSTlYQnZFTUNzWWYwbnJTcnZmaFM2RWZ1CkwydG1YeU5IU1ZPVmt6ZjlF
ZWI4VGtqd05KclhsdUVaV04wcGIxUHJLbmpBT3JvVi9teC9kRTBFTnM4QkgrbWsKMzZkM0VkOCtH
a0RTOUlVWDJqZFZUTnFiSGUzVjVaWXhZVVRWcVZlNkZUQm9mZmVURU9sQlFaTWRNdmcyOTc3Qwpa
UmRLWGZKNUZhZnlELzFqOWEzOXVqSm9ZVHJ2Y1lVZWRJK1RLN3ZCREJiNE5YR1dlL1djaDltV0NV
VWtRVkZICnRKQ2tlZnlQTG42aVFVeWJHa29JRzJsT3lqUmF4dGlValZ3NThLb0dpb0VkbjFBR2ov
VVBtQjIrOWl0amVtR2wKeHpneVdCdEdxUXpTakROMkpvdEQrdVN3TmJxNHRDL2g5SjJGeDlOUGc5
TkxXeGlDRzNvZkRuTWxjZElJOVpDcwpYUnVSMkRsMGhxOHJJTjNYRmxzMgo9ZDdpRAotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============9048964312184818780==--