From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 2/4] network: Support bridge mode for zones
Date: Thu, 29 Dec 2016 20:37:32 +0100
Message-ID: <1483040254-15683-2-git-send-email-jonatan.schlag@ipfire.org>
In-Reply-To: <1483040254-15683-1-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3902638134095042185=="
List-Id: <development.lists.ipfire.org>

--===============3902638134095042185==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

This bridge mode is supposed to be used for virtual environments
to create a network zone as a bridge and have virtual machines inside
it. Other physical interfaces can also be added to the bridge.

This is very similar to the MACVTAP bridge feature but still works
when the link of any (or all) physical interfaces is down.

Fixes: #11252

Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
 config/udev/network-hotplug-macvtap | 100 ++++++++++++++++++++++++++++++----=
--
 config/udev/network-hotplug-rename  |   4 ++
 2 files changed, 88 insertions(+), 16 deletions(-)

diff --git a/config/udev/network-hotplug-macvtap b/config/udev/network-hotplu=
g-macvtap
index 7f5da12..ff6d20a 100644
--- a/config/udev/network-hotplug-macvtap
+++ b/config/udev/network-hotplug-macvtap
@@ -23,24 +23,92 @@
=20
 [ -n "${INTERFACE}" ] || exit 2
=20
-PHYSICAL_INTERFACE=3D"${INTERFACE}"
-VIRTUAL_INTERFACE=3D"${INTERFACE%phys}"
-#VIRTUAL_INTERFACE=3D"${VIRTUAL_INTERFACE}0"
+eval $(/usr/local/bin/readhash /var/ipfire/ethernet/settings)
=20
-# Do nothing if the physical interface does not end with "phys"
-case "${PHYSICAL_INTERFACE}" in
-	*phys)
+detect_zone() {
+	local intf=3D"${INTERFACE%0*}"
+	intf=3D"${intf^^}"
+
+	local zone
+	for zone in GREEN BLUE ORANGE RED; do
+		# Try to find if INTERFACE is the *phys version of a zone
+		if [ "${intf}" =3D "${zone}" ]; then
+			echo "${zone}"
+			return 0
+		fi
+
+		# Try to find out if this INTERFACE is a slave of a zone
+		local slave
+		for slave in $(get_value "${zone}_SLAVES"); do
+			if [ "${INTERFACE}" =3D "${slave}" ]; then
+				echo "${zone}"
+				return 0
+			fi
+		done
+	done
+
+	return 1
+}
+
+get_value() {
+	echo "${!1}"
+}
+
+random_mac_address() {
+	local address=3D"02"
+
+	for i in $(seq 5); do
+		printf -v address "${address}:%02x" "$(( RANDOM % 256 ))"
+	done
+
+	echo "${address}"
+}
+
+# Try to detect which zone we are operating on
+ZONE=3D$(detect_zone)
+
+# Cannot proceed if we could not find a zone
+if [ -z "${ZONE}" ]; then
+	exit 0
+fi
+
+# Determine the mode of this zone
+MODE=3D"$(get_value "${ZONE}_MODE")"
+
+# The name of the virtual bridge
+BRIDGE=3D"$(get_value "${ZONE}_DEV")"
+
+case "${MODE}" in
+	bridge)
+		ADDRESS=3D"$(get_value "${ZONE}_MACADDR")"
+		[ -n "${ADDRESS}" ] || ADDRESS=3D"$(random_mac_address)"
+
+		# We need to create the bridge if it doesn't exist, yet
+		if [ ! -d "/sys/class/net/${BRIDGE}" ]; then
+			ip link add "${BRIDGE}" address "${ADDRESS}" type bridge
+			#ip link set "${BRIDGE}" up
+		fi
+
+		# Attach the physical device
+		ip link set dev "${INTERFACE}" master "${BRIDGE}"
+		ip link set dev "${INTERFACE}" up
 		;;
-	*)
-		exit 0
+
+	macvtap)
+		ADDRESS=3D"$(</sys/class/net/${INTERFACE}/address)"
+		GENERATED_ADDRESS=3D$(random_mac_address)
+
+		ip link add link "${INTERFACE}" "${BRIDGE}" address "${ADDRESS}" type macv=
lan mode bridge
+		ip link set "${INTERFACE}" address "${GENERATED_ADDRESS}"
+		ip link set "${INTERFACE}" up
 		;;
-esac
=20
-ADDRESS=3D"$(</sys/class/net/${PHYSICAL_INTERFACE}/address)"
-rand=3D"$(</proc/sys/kernel/random/uuid)"
-rand=3D"${rand//-/}"
-GENERATED_ADDRESS=3D$(echo "02:${rand:0:2}:${rand:2:2}:${rand:4:2}:${rand:6:=
2}:${rand:8:2}")
+	"")
+		exit 0
+		;;
=20
-ip link add link "${PHYSICAL_INTERFACE}" "${VIRTUAL_INTERFACE}" address "${A=
DDRESS}" type macvlan mode bridge
-ip link set "${PHYSICAL_INTERFACE}" address "${GENERATED_ADDRESS}"
-ip link set "${PHYSICAL_INTERFACE}" up
+	*)
+		logger -t "network" "Unhandled mode '${MODE}' for '${ZONE}' (${INTERFACE})"
+		exit 1
+		;;
+esac
diff --git a/config/udev/network-hotplug-rename b/config/udev/network-hotplug=
-rename
index 1f8d5e1..294bb78 100644
--- a/config/udev/network-hotplug-rename
+++ b/config/udev/network-hotplug-rename
@@ -68,6 +68,10 @@ for zone in ${ZONES}; do
 	# If a matching interface has been found we will
 	# print the name to which udev will rename it.
 	case "${!mode}" in
+		bridge)
+			echo "${!device}phys"
+			;;
+
 		macvtap)
 			# MACVTAP mode doesn't work for WiFi devices
 			if [ -d "/sys/class/net/${INTERFACE}/phy80211" ]; then
--=20
2.7.4


--===============3902638134095042185==--