public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] intltool: Enable testsuite.
Date: Thu, 12 Jan 2017 10:18:57 +0100	[thread overview]
Message-ID: <1484212737.10307.0.camel@ipfire.org> (raw)
In-Reply-To: <1474716185.2757.286.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

Hello Michael,

thanks for pointing these things out, I'll sent a new patch to this
list.

Best regards,

-Stefan
> Hi,
> 
> On Fri, 2016-09-23 at 11:15 +0200, Stefan Schantl wrote:
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> >  intltool/intltool.nm | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> > 
> > diff --git a/intltool/intltool.nm b/intltool/intltool.nm
> > index 1f0311c..a217ea3 100644
> > --- a/intltool/intltool.nm
> > +++ b/intltool/intltool.nm
> > @@ -5,7 +5,7 @@
> >  
> >  name       = intltool
> >  version    = 0.51.0
> > -release    = 1
> > +release    = 2
> >  arch       = noarch
> >  
> >  groups     = Localization/Tools
> > @@ -29,7 +29,18 @@ build
> >  	end
> >  
> >  	configure_options += \
> > -		--mandir=/usr/share/man
> > +		--mandir=%{mandir}
> 
> This is always automatically set.
> 
> > +	test
> > +		if ! make check; then
> > +			find . -type f -name 'test-suite.log' |
> > while read
> > trs; do
> > +				echo "BEGIN " ${trs}; cat ${trs}
> > 1>&2;
> > +			done
> > +
> > +			echo  "Exiting abnormally due to make
> > check failure
> > above" 1>&2
> > +			exit 1
> > +		fi
> > +	end
> >  end
> 
> What is this needed for?
> 
> >  
> >  packages

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-01-12  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23  9:15 Stefan Schantl
2016-09-24 11:23 ` Michael Tremer
2017-01-12  9:18   ` Stefan Schantl [this message]
2017-01-12  9:19     ` [PATCHv2] " Stefan Schantl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484212737.10307.0.camel@ipfire.org \
    --to=stefan.schantl@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox