public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: merge request: initscript cleanup
Date: Wed, 08 Mar 2017 16:04:44 +0100	[thread overview]
Message-ID: <1488985484.2740.0@mail01.ipfire.org> (raw)
In-Reply-To: <1488975710.24229.40.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hi Michael

Am Mi, 8. Mär, 2017 um 1:21 schrieb Michael Tremer 
<michael.tremer(a)ipfire.org>:
> Hey Jonatan,
> 
> thanks for working on this. This is well needed since installing 
> initscripts
> always was very messy and often caused lots of pain.
> 
> Before I merge this I would like to know if any of this needs to be 
> shipped with
> the next core update or if everything should be the same after 
> applying the
> patches - we would just have cleaner code then, obviously.

 From my point of nothing needs to be shipped with the next core 
update. We just change the way the build process is running. The 
content of the initscript are not changed nor which files will be 
shipped.
Everything should be the same.

Regards Jonatan

> Thanks for not sending this is a patchset of >50 patches. :D
> 
> Best,
> -Michael
> 
> On Tue, 2017-03-07 at 14:45 +0100, Jonatan Schlag wrote:
>>  Hi,
>> 
>>  this is the merge request to clean up the handling of initscripts in
>>  the build process of ipfire 2.
>> 
>>  Please pull from
>>  git://git.ipfire.org/people/jschlag/ipfire-2.x.git 
>> initscripts-cleanup
>> 
>>  to get these changes:
>>  - a new macro to install initscripts for packages
>>  ($(call INSTALL_INITSCRIPT,*name of the initscript*))
>>  - the initscripts for packages are now stored in
>>  /src/initscripts/packages
>>  - the initscript for the system are stored in
>>  /src/initscripts/system
>>  - the rootfile of the the initscript lfs file contain now only the
>>  initscripts for the system, the initscript for each package are 
>> located
>>  in the rootfile of the package
>> 
>>  This makes maintainering of the initscript in IPFire a lot easier,
>>  because the initscripts for teh system and for the packages are 
>> better
>>  seperated. The new macro makes the lfs files a little bit more 
>> cleaner.
>> 
>>  Thanks in advance,
>> 
>>  Jonatan




  reply	other threads:[~2017-03-08 15:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 13:45 Jonatan Schlag
2017-03-08 12:21 ` Michael Tremer
2017-03-08 15:04   ` Jonatan Schlag [this message]
2017-03-09 11:08     ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488985484.2740.0@mail01.ipfire.org \
    --to=jonatan.schlag@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox