public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Disable netfilter on all bridges per default
Date: Sun, 12 Mar 2017 14:56:50 +0000	[thread overview]
Message-ID: <1489330610.10391.53.camel@ipfire.org> (raw)
In-Reply-To: <1489219839-659-1-git-send-email-jonatan.schlag@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

Thanks for submitting this patch.

This is the default in IPFire 3, so it makes sense to backport that behaviour to
IPFire 2 as well.

Best,
-Michael

On Sat, 2017-03-11 at 09:10 +0100, Jonatan Schlag wrote:
> Fixes: #11301
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  config/etc/sysctl.conf                    | 5 +++++
>  config/rootfiles/core/110/filelists/files | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/config/etc/sysctl.conf b/config/etc/sysctl.conf
> index e2e3d81..ad56240 100644
> --- a/config/etc/sysctl.conf
> +++ b/config/etc/sysctl.conf
> @@ -34,3 +34,8 @@ net.ipv6.conf.default.disable_ipv6 = 1
>  
>  # Enable netfilter accounting
>  net.netfilter.nf_conntrack_acct=1
> +
> +# Disable netfilter on bridges.
> +net.bridge.bridge-nf-call-ip6tables = 0
> +net.bridge.bridge-nf-call-iptables = 0
> +net.bridge.bridge-nf-call-arptables = 0
> diff --git a/config/rootfiles/core/110/filelists/files
> b/config/rootfiles/core/110/filelists/files
> index b996e48..f06b6d5 100644
> --- a/config/rootfiles/core/110/filelists/files
> +++ b/config/rootfiles/core/110/filelists/files
> @@ -2,6 +2,7 @@ etc/system-release
>  etc/issue
>  etc/httpd/conf/server-tuning.conf
>  etc/rc.d/init.d/unbound
> +etc/sysctl.conf
>  srv/web/ipfire/cgi-bin/index.cgi
>  srv/web/ipfire/cgi-bin/vpnmain.cgi
>  usr/lib/libssp.so.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-03-12 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11  8:10 Jonatan Schlag
2017-03-12 14:56 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489330610.10391.53.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox