public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] unbound 1.6.1: Linking against libevent2
Date: Mon, 24 Apr 2017 10:19:01 +0100	[thread overview]
Message-ID: <1493025541.3373.14.camel@ipfire.org> (raw)
In-Reply-To: <20170421170021.17772-1-matthias.fischer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]

Thank you. Merged!

On Fri, 2017-04-21 at 19:00 +0200, Matthias Fischer wrote:
> Hi,
> 
> this was triggered by unbound-users(a)unbound.net - it seems that the
> 'configure'-option '--with-libevent-support' is not enough:
> 
> ***SNIP***
> ...
> When building unbound with --with-libevent support, the make
> install phase should also call make unbound-event-install or else
> unbound-event.h does not get installed and the header file for
> using the unbound event functionality is not available.
> ...
> This install is triggered by the option --enable-event-api. Just
> enabling --with-libevent does not trigger the install by itself.
> 
> Best regards,
> Wouter
> ...
> ***SNAP***
> 
> I built 'unbound' this way - its running without any problems so far.
> 
> Best,
> Matthias
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  config/rootfiles/common/unbound | 1 +
>  lfs/unbound                     | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/config/rootfiles/common/unbound b/config/rootfiles/common/unbound
> index a94ea2564..824567e1f 100644
> --- a/config/rootfiles/common/unbound
> +++ b/config/rootfiles/common/unbound
> @@ -6,6 +6,7 @@ etc/unbound/icannbundle.pem
>  etc/unbound/local.d
>  etc/unbound/root.hints
>  etc/unbound/unbound.conf
> +#usr/include/unbound-event.h
>  #usr/include/unbound.h
>  #usr/lib/libunbound.la
>  #usr/lib/libunbound.so
> diff --git a/lfs/unbound b/lfs/unbound
> index f361f24f0..d78bd9509 100644
> --- a/lfs/unbound
> +++ b/lfs/unbound
> @@ -78,7 +78,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  			--with-pidfile=/var/run/unbound.pid \
>  			--with-rootkey-file=/var/lib/unbound/root.key \
>  			--disable-static \
> -			--with-libevent
> +			--with-libevent \
> +			--enable-event-api
> +
>  	cd $(DIR_APP) && make $(MAKETUNING)
>  	cd $(DIR_APP) && make install
>  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-04-24  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 17:00 Matthias Fischer
2017-04-24  9:19 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493025541.3373.14.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox