public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [PATCH] unbound 1.6.1: Linking against libevent2
@ 2017-04-21 17:00 Matthias Fischer
  2017-04-24  9:19 ` Michael Tremer
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Fischer @ 2017-04-21 17:00 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

Hi,

this was triggered by unbound-users(a)unbound.net - it seems that the
'configure'-option '--with-libevent-support' is not enough:

***SNIP***
...
When building unbound with --with-libevent support, the make
install phase should also call make unbound-event-install or else
unbound-event.h does not get installed and the header file for
using the unbound event functionality is not available.
...
This install is triggered by the option --enable-event-api. Just
enabling --with-libevent does not trigger the install by itself.

Best regards,
Wouter
...
***SNAP***

I built 'unbound' this way - its running without any problems so far.

Best,
Matthias

Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
 config/rootfiles/common/unbound | 1 +
 lfs/unbound                     | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/config/rootfiles/common/unbound b/config/rootfiles/common/unbound
index a94ea2564..824567e1f 100644
--- a/config/rootfiles/common/unbound
+++ b/config/rootfiles/common/unbound
@@ -6,6 +6,7 @@ etc/unbound/icannbundle.pem
 etc/unbound/local.d
 etc/unbound/root.hints
 etc/unbound/unbound.conf
+#usr/include/unbound-event.h
 #usr/include/unbound.h
 #usr/lib/libunbound.la
 #usr/lib/libunbound.so
diff --git a/lfs/unbound b/lfs/unbound
index f361f24f0..d78bd9509 100644
--- a/lfs/unbound
+++ b/lfs/unbound
@@ -78,7 +78,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 			--with-pidfile=/var/run/unbound.pid \
 			--with-rootkey-file=/var/lib/unbound/root.key \
 			--disable-static \
-			--with-libevent
+			--with-libevent \
+			--enable-event-api
+
 	cd $(DIR_APP) && make $(MAKETUNING)
 	cd $(DIR_APP) && make install
 
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] unbound 1.6.1: Linking against libevent2
  2017-04-21 17:00 [PATCH] unbound 1.6.1: Linking against libevent2 Matthias Fischer
@ 2017-04-24  9:19 ` Michael Tremer
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Tremer @ 2017-04-24  9:19 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]

Thank you. Merged!

On Fri, 2017-04-21 at 19:00 +0200, Matthias Fischer wrote:
> Hi,
> 
> this was triggered by unbound-users(a)unbound.net - it seems that the
> 'configure'-option '--with-libevent-support' is not enough:
> 
> ***SNIP***
> ...
> When building unbound with --with-libevent support, the make
> install phase should also call make unbound-event-install or else
> unbound-event.h does not get installed and the header file for
> using the unbound event functionality is not available.
> ...
> This install is triggered by the option --enable-event-api. Just
> enabling --with-libevent does not trigger the install by itself.
> 
> Best regards,
> Wouter
> ...
> ***SNAP***
> 
> I built 'unbound' this way - its running without any problems so far.
> 
> Best,
> Matthias
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  config/rootfiles/common/unbound | 1 +
>  lfs/unbound                     | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/config/rootfiles/common/unbound b/config/rootfiles/common/unbound
> index a94ea2564..824567e1f 100644
> --- a/config/rootfiles/common/unbound
> +++ b/config/rootfiles/common/unbound
> @@ -6,6 +6,7 @@ etc/unbound/icannbundle.pem
>  etc/unbound/local.d
>  etc/unbound/root.hints
>  etc/unbound/unbound.conf
> +#usr/include/unbound-event.h
>  #usr/include/unbound.h
>  #usr/lib/libunbound.la
>  #usr/lib/libunbound.so
> diff --git a/lfs/unbound b/lfs/unbound
> index f361f24f0..d78bd9509 100644
> --- a/lfs/unbound
> +++ b/lfs/unbound
> @@ -78,7 +78,9 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  			--with-pidfile=/var/run/unbound.pid \
>  			--with-rootkey-file=/var/lib/unbound/root.key \
>  			--disable-static \
> -			--with-libevent
> +			--with-libevent \
> +			--enable-event-api
> +
>  	cd $(DIR_APP) && make $(MAKETUNING)
>  	cd $(DIR_APP) && make install
>  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-24  9:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-21 17:00 [PATCH] unbound 1.6.1: Linking against libevent2 Matthias Fischer
2017-04-24  9:19 ` Michael Tremer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox