From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Cleanup2017: Delete unused function from fwhosts.cgi
Date: Thu, 08 Jun 2017 15:14:07 +0100 [thread overview]
Message-ID: <1496931247.21214.13.camel@ipfire.org> (raw)
In-Reply-To: <1496903032-6427-1-git-send-email-alexander.marx@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
Hey,
yes indeed. There is much more where this one came from...
-Michael
On Thu, 2017-06-08 at 08:23 +0200, Alexander Marx wrote:
> This function is not used by any other script.
>
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> ---
> html/cgi-bin/fwhosts.cgi | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
> index 25ab489..a2ade8a 100644
> --- a/html/cgi-bin/fwhosts.cgi
> +++ b/html/cgi-bin/fwhosts.cgi
> @@ -2555,18 +2555,6 @@ sub checkip
> }
> return 1;
> }
> -sub checksubnet
> -{
> - my %hash=%{(shift)};
> - &General::readhasharray("$confignet", \%hash);
> - foreach my $key (keys %hash) {
> - if(&General::IpInSubnet($fwhostsettings{'IP'},$hash{$key}[1],
> $hash{$key}[2]))
> - {
> - return 1;
> - }
> - }
> - return 0;
> -}
> sub checkservicegroup
> {
> &General::readhasharray("$configsrvgrp", \%customservicegrp);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-06-08 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 6:23 Alexander Marx
2017-06-08 14:14 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496931247.21214.13.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox