[PATCH] Cleanup2017: Delete unused function from fwhosts.cgi

[PATCH] Cleanup2017: Delete unused function from fwhosts.cgi

[Alexander Marx]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

This function is not used by any other script.

Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
---
 html/cgi-bin/fwhosts.cgi | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
index 25ab489..a2ade8a 100644
--- a/html/cgi-bin/fwhosts.cgi
+++ b/html/cgi-bin/fwhosts.cgi
@@ -2555,18 +2555,6 @@ sub checkip
 	}
 	return 1;
 }
-sub checksubnet
-{
-	my %hash=%{(shift)};
-	&General::readhasharray("$confignet", \%hash);
-	foreach my $key (keys %hash) {
-		if(&General::IpInSubnet($fwhostsettings{'IP'},$hash{$key}[1],$hash{$key}[2]))
-		{
-			return 1;
-		}
-	}
-	return 0;
-}
 sub checkservicegroup
 {
 	&General::readhasharray("$configsrvgrp", \%customservicegrp);
-- 
2.7.4

Re: [PATCH] Cleanup2017: Delete unused function from fwhosts.cgi

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

Hey,

yes indeed. There is much more where this one came from...

-Michael

On Thu, 2017-06-08 at 08:23 +0200, Alexander Marx wrote:
> This function is not used by any other script.
> 
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> ---
>  html/cgi-bin/fwhosts.cgi | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
> index 25ab489..a2ade8a 100644
> --- a/html/cgi-bin/fwhosts.cgi
> +++ b/html/cgi-bin/fwhosts.cgi
> @@ -2555,18 +2555,6 @@ sub checkip
>  	}
>  	return 1;
>  }
> -sub checksubnet
> -{
> -	my %hash=%{(shift)};
> -	&General::readhasharray("$confignet", \%hash);
> -	foreach my $key (keys %hash) {
> -		if(&General::IpInSubnet($fwhostsettings{'IP'},$hash{$key}[1],
> $hash{$key}[2]))
> -		{
> -			return 1;
> -		}
> -	}
> -	return 0;
> -}
>  sub checkservicegroup
>  {
>  	&General::readhasharray("$configsrvgrp", \%customservicegrp);

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]