From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] kernel: enable CONFIG_SCHED_STACK_END_CHECK on x86_64,
 armv5tel and aarch64
Date: Mon, 20 Apr 2020 08:12:45 +0100
Message-ID: <149A6FED-3B6F-4A8A-A151-DA5FB00654EB@ipfire.org>
In-Reply-To: <981acf6e-fbb8-e1e8-0a5b-fc95f80b2763@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4507156253375285440=="
List-Id: <development.lists.ipfire.org>

--===============4507156253375285440==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 18 Apr 2020, at 09:42, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
>> This option checks for a stack overrun on calls to schedule(). If the stack
>> end location is found to be over written always panic as the content of the
>> corrupted region can no longer be trusted. This is to ensure no erroneous
>> behaviour occurs which could result in data corruption or a sporadic crash=
 at a
>> later stage once the region is examined. The runtime overhead introduced is
>> minimal.
>=20
> Fixes: #12376
>=20
> Cc: Arne Fitzenreiter <arne.fitzenreiter(a)ipfire.org>
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.aarch64-ipfire        | 2 +-
> config/kernel/kernel.config.armv5tel-ipfire-multi | 2 +-
> config/kernel/kernel.config.x86_64-ipfire         | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/ker=
nel.config.aarch64-ipfire
> index 32ad2df07..2043e044a 100644
> --- a/config/kernel/kernel.config.aarch64-ipfire
> +++ b/config/kernel/kernel.config.aarch64-ipfire
> @@ -6442,7 +6442,7 @@ CONFIG_PANIC_TIMEOUT=3D0
> CONFIG_SCHED_DEBUG=3Dy
> CONFIG_SCHED_INFO=3Dy
> CONFIG_SCHEDSTATS=3Dy
> -# CONFIG_SCHED_STACK_END_CHECK is not set
> +CONFIG_SCHED_STACK_END_CHECK=3Dy
> # CONFIG_DEBUG_TIMEKEEPING is not set
>=20
> #
> diff --git a/config/kernel/kernel.config.armv5tel-ipfire-multi b/config/ker=
nel/kernel.config.armv5tel-ipfire-multi
> index cfa766005..dc09d33de 100644
> --- a/config/kernel/kernel.config.armv5tel-ipfire-multi
> +++ b/config/kernel/kernel.config.armv5tel-ipfire-multi
> @@ -6924,7 +6924,7 @@ CONFIG_PANIC_TIMEOUT=3D0
> CONFIG_SCHED_DEBUG=3Dy
> CONFIG_SCHED_INFO=3Dy
> CONFIG_SCHEDSTATS=3Dy
> -# CONFIG_SCHED_STACK_END_CHECK is not set
> +CONFIG_SCHED_STACK_END_CHECK=3Dy
> # CONFIG_DEBUG_TIMEKEEPING is not set
>=20
> #
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index b16d13504..c4b1a7ae3 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -6429,7 +6429,7 @@ CONFIG_PANIC_TIMEOUT=3D0
> CONFIG_SCHED_DEBUG=3Dy
> CONFIG_SCHED_INFO=3Dy
> CONFIG_SCHEDSTATS=3Dy
> -# CONFIG_SCHED_STACK_END_CHECK is not set
> +CONFIG_SCHED_STACK_END_CHECK=3Dy
> # CONFIG_DEBUG_TIMEKEEPING is not set
>=20
> #
> --=20
> 2.16.4


--===============4507156253375285440==--