public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cups: Remove 5 minutes delay in start_service line in install.sh paks file
Date: Sun, 09 Jul 2023 15:01:00 +0000	[thread overview]
Message-ID: <14ea0aae-222b-1186-6473-2b6c1641d19e@ipfire.org> (raw)
In-Reply-To: <20230704191733.1290026-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> - When cups is installed (including when doing a Core Update that includes a cups update)
>    the 5 min delay for starting cups means that it has not restarted by the time that the
>    reboot for the CU has been started. There are then error messages that say that cups
>    couldn't be stopped as it was not running.
> - When a normal reboot is carried out withoutr any update of cups then the startup has
>    no delay and it starts without any trouble.
> - This patch removes the 300 secs delay from the start_service line in the install.sh paks
>    file.
> - The PAK_VER is bumped to ensure that this change is shipped
> 
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>  lfs/cups                 | 2 +-
>  src/paks/cups/install.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/cups b/lfs/cups
> index 70839736f..cae829432 100644
> --- a/lfs/cups
> +++ b/lfs/cups
> @@ -33,7 +33,7 @@ DL_FROM    = $(URL_IPFIRE)
>  DIR_APP    = $(DIR_SRC)/cups-$(VER)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  PROG       = cups
> -PAK_VER    = 36
> +PAK_VER    = 37
>  
>  DEPS       = avahi cups-filters dbus ghostscript libexif
>  
> diff --git a/src/paks/cups/install.sh b/src/paks/cups/install.sh
> index cc5866971..f1d45b697 100644
> --- a/src/paks/cups/install.sh
> +++ b/src/paks/cups/install.sh
> @@ -25,7 +25,7 @@
>  extract_files
>  restore_backup "${NAME}"
>  /etc/init.d/messagebus reload
> -start_service --delay 300 --background ${NAME}
> +start_service --background ${NAME}
>  ln -svf ../init.d/cups /etc/rc.d/rc0.d/K00cups
>  ln -svf ../init.d/cups /etc/rc.d/rc3.d/S25cups
>  ln -svf ../init.d/cups /etc/rc.d/rc6.d/K00cups

      reply	other threads:[~2023-07-09 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 19:17 Adolf Belka
2023-07-09 15:01 ` Peter Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14ea0aae-222b-1186-6473-2b6c1641d19e@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox