From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cups: Remove 5 minutes delay in start_service line in
 install.sh paks file
Date: Sun, 09 Jul 2023 15:01:00 +0000
Message-ID: <14ea0aae-222b-1186-6473-2b6c1641d19e@ipfire.org>
In-Reply-To: <20230704191733.1290026-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0501699731620875692=="
List-Id: <development.lists.ipfire.org>

--===============0501699731620875692==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> - When cups is installed (including when doing a Core Update that includes =
a cups update)
>    the 5 min delay for starting cups means that it has not restarted by the=
 time that the
>    reboot for the CU has been started. There are then error messages that s=
ay that cups
>    couldn't be stopped as it was not running.
> - When a normal reboot is carried out withoutr any update of cups then the =
startup has
>    no delay and it starts without any trouble.
> - This patch removes the 300 secs delay from the start_service line in the =
install.sh paks
>    file.
> - The PAK_VER is bumped to ensure that this change is shipped
>=20
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>  lfs/cups                 | 2 +-
>  src/paks/cups/install.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/lfs/cups b/lfs/cups
> index 70839736f..cae829432 100644
> --- a/lfs/cups
> +++ b/lfs/cups
> @@ -33,7 +33,7 @@ DL_FROM    =3D $(URL_IPFIRE)
>  DIR_APP    =3D $(DIR_SRC)/cups-$(VER)
>  TARGET     =3D $(DIR_INFO)/$(THISAPP)
>  PROG       =3D cups
> -PAK_VER    =3D 36
> +PAK_VER    =3D 37
> =20
>  DEPS       =3D avahi cups-filters dbus ghostscript libexif
> =20
> diff --git a/src/paks/cups/install.sh b/src/paks/cups/install.sh
> index cc5866971..f1d45b697 100644
> --- a/src/paks/cups/install.sh
> +++ b/src/paks/cups/install.sh
> @@ -25,7 +25,7 @@
>  extract_files
>  restore_backup "${NAME}"
>  /etc/init.d/messagebus reload
> -start_service --delay 300 --background ${NAME}
> +start_service --background ${NAME}
>  ln -svf ../init.d/cups /etc/rc.d/rc0.d/K00cups
>  ln -svf ../init.d/cups /etc/rc.d/rc3.d/S25cups
>  ln -svf ../init.d/cups /etc/rc.d/rc6.d/K00cups

--===============0501699731620875692==--