From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] rules.pl: fix missing blank in 'if'-condition
Date: Mon, 21 Aug 2017 12:17:52 +0100
Message-ID: <1503314272.2673.11.camel@ipfire.org>
In-Reply-To: <20170819113058.25195-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0807845849152985632=="
List-Id: <development.lists.ipfire.org>

--===============0807845849152985632==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi,

this has been set to deferred on Patchwork. Why?

Best,
-Michael

On Sat, 2017-08-19 at 13:30 +0200, Matthias Fischer wrote:
> Triggered by https://forum.ipfire.org/viewtopic.php?f=22&t=19304
> 
> Best,
> Matthias
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  config/firewall/rules.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
> index 8b0c6ddc8..efbe9cfef 100644
> --- a/config/firewall/rules.pl
> +++ b/config/firewall/rules.pl
> @@ -608,7 +608,7 @@ sub geoipblock {
>  	# create iptables rules, if blocking this country
>  	# is enabled.
>  	foreach my $location (@locations) {
> -		if($geoipsettings{$location} eq "on") {
> +		if ($geoipsettings{$location} eq "on") {
>  			run("$IPTABLES -A GEOIPBLOCK -m geoip --src-cc $location -j DROP");
>  		}
>  	}

--===============0807845849152985632==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl
Mnlwa3R4Z0hudy8yK1FDUWNGQWxtYXdXQUFDZ2tRZ0hudy8yK1EKQ1FjMk54QUF0Y285LzgvYVpL
RmwzekNXdkc3ZGZ5WGRjbWgzTjdxRVBaSTk3SHNUSVZTY1RuWWU1U3loSkZGeApHclJqNlhveUsv
aUhIb0Nrcm1KYS9iUlE2U0JyWVNCOHJyOGI4OEQ2cVZNOWw1by8xdDNwSjBhdStHTm41QlYvClZr
bzFMcU9PVlplYUliUW00Ny8rOVhrZEVKa0VVOTNBVFpnMzZBN1E3R2xuVXBDRzFMUWF3WlY5VlZN
RXpZdWgKcElxM2h3Und2VjQ5THIvb2Rub0Zod0lxYzRtZlRCWHIvUlJ1SWtCQWE0MmJzUXJqWTI4
bTd2cUlvaVhYK3dkRgpoVS9nL2tpU2dHV0xiMXVOMThLNFVVdDBEazJSSElSanljc2prMG4zdDc1
Z0JPZ2pIZ0xDY0Q2aXFkQUs1d2o2CjVEQTdBd20yNERrdVZTaUErMWtVc0VOMWQ4YkU4ci80NjEy
cGU3K1JLNlNBc3RSU1EvcStna080aU9zV2EvRy8KUGNCY1dMMU0zV1RyV05ubFZySWVLN1YvT09J
S0tYMnhDWVVJMmFFNldMckl3SzdDaENWSzJrcmdlV1U3TmQ4RwpZa3dKTWY0Rjd4dHVsLzg1ZlF3
OWtJWUhkc0FIMWR4MXRaQ3JtOVpPY0RWRityeGNLT3J5UTU4UGJXWHp2b29GClI4K0pVYWVKSFdI
Q1lzQWZyd1hiQURFN043WkNsQnQxNmVWNHhSRUlGRXVDZkxCZ3YxeWFNbzhOSFI0dVV6MDYKNUg1
REIvSTJucWlUWXZhNGpFUEMxQXlEUnFza2FiaHBCbmJNVnVpSVFkeCtuVkczRGIwTThramwxUDNr
SFZPaApUQ0lTUnNjWHhLU2VJWTUzTERQOTB2NVpRUGh2Wnc5OHhZTHBFcklMTWNHdFFiWVlTVUE9
Cj1wcEp2Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============0807845849152985632==--