From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] proxy.cgi: Some cosmetics for the absolutely lazy ones... ; -) Date: Wed, 20 Sep 2017 22:22:34 +0100 Message-ID: <1505942554.4381.20.camel@ipfire.org> In-Reply-To: <20170917131812.2865-1-matthias.fischer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8466382684346206554==" List-Id: --===============8466382684346206554== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, it would be way better to have the link in the CGI and not in the translation file. That way translators wouldn't have to deal with any of the markup and what is even worse: being able to inject any kind of HTML into the generated output. But that is a different issue. Would you be up for sending a corrected patch? I like the idea to get a reference so people find the correct configuration page easily. Best, -Michael On Sun, 2017-09-17 at 15:18 +0200, Matthias Fischer wrote: > Added clickable links for 'URL filter' and 'Update accelerator' for faster = access. >=20 > Best, > Matthias >=20 > Signed-off-by: Matthias Fischer > --- > html/cgi-bin/proxy.cgi | 4 ++-- > langs/de/cgi-bin/de.pl | 2 ++ > langs/en/cgi-bin/en.pl | 2 ++ > 3 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi > index 0b7d36c3c..1a5985d17 100644 > --- a/html/cgi-bin/proxy.cgi > +++ b/html/cgi-bin/proxy.cgi > @@ -1054,11 +1054,11 @@ if ( -e "/usr/bin/squidclamav" ) { > } else { > print ""; > } > -print "".$Lang::tr{'advproxy url filter'}."
"; > +print "".$Lang::tr{'advproxy url filter link'}."=
"; > print $Lang::tr{'advproxy enabled'}."
"; > print "+ ".int(($count**(1/3)) * 6); > print ""; > -print "".$Lang::tr{'advproxy update accelerator'}."<= /b>
"; > +print "".$Lang::tr{'advproxy update accelerator link= '}."
"; > print $Lang::tr{'advproxy enabled'}."
"; > print "+ ".int(($count**(1/3)) * 5); > print ""; > diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl > index 7bc1c495d..45e45aa2e 100644 > --- a/langs/de/cgi-bin/de.pl > +++ b/langs/de/cgi-bin/de.pl > @@ -327,12 +327,14 @@ > 'advproxy unrestricted ip clients' =3D> 'Uneingeschr=C3=A4nkte IP-Adressen= (eine pro Zeile)', > 'advproxy unrestricted mac clients' =3D> 'Uneingeschr=C3=A4nkte MAC-Adress= en (eine pro Zeile)', > 'advproxy update accelerator' =3D> 'Update-Accelerator', > +'advproxy update accelerator link' =3D> 'Update-Accelerator', > 'advproxy update notification' =3D> 'Update-Benachrichtigung!', > 'advproxy upstream password' =3D> 'Proxy-Passwort', > 'advproxy upstream proxy' =3D> 'Vorgelagerter Proxy', > 'advproxy upstream proxy host:port' =3D> 'Vorgelagerter Proxy (Host:Port)', > 'advproxy upstream username' =3D> 'Proxy-Benutzername', > 'advproxy url filter' =3D> 'URL-Filter', > +'advproxy url filter link' =3D> 'URL-Fi= lter', > 'advproxy username forwarding' =3D> ' Benutzernamen weiterleiten', > 'advproxy via forwarding' =3D> 'Proxy-Adresse weiterleiten', > 'advproxy visible hostname' =3D> 'Sichtbarer Hostname', > diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl > index 9732a6e9d..adebbf4b4 100644 > --- a/langs/en/cgi-bin/en.pl > +++ b/langs/en/cgi-bin/en.pl > @@ -327,6 +327,7 @@ > 'advproxy unrestricted ip clients' =3D> 'Unrestricted IP addresses (one pe= r line)', > 'advproxy unrestricted mac clients' =3D> 'Unrestricted MAC addresses (one = per line)', > 'advproxy update accelerator' =3D> 'Update accelerator', > +'advproxy update accelerator link' =3D> 'Update accelerator', > 'advproxy update information' =3D> 'There is an updated version available = for download. Visit htt= p://www.advproxy.net; for more information.', > 'advproxy update notification' =3D> 'Update notification!', > 'advproxy upstream password' =3D> 'Upstream password', > @@ -334,6 +335,7 @@ > 'advproxy upstream proxy host:port' =3D> 'Upstream proxy (host:port)', > 'advproxy upstream username' =3D> 'Upstream username', > 'advproxy url filter' =3D> 'URL filter', > +'advproxy url filter link' =3D> 'URL fi= lter', > 'advproxy username forwarding' =3D> 'Username forwarding', > 'advproxy via forwarding' =3D> 'Proxy address forwarding', > 'advproxy visible hostname' =3D> 'Visible hostname', --===============8466382684346206554== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl Mnlwa3R4Z0hudy8yK1FDUWNGQWxuQzNCb0FDZ2tRZ0hudy8yK1EKQ1FmOEh4QUFnc2piM0hWVzd0 QllIeTdGckVsamRQZ1NINWdNeGJibGNrcFcxenBTbzhTcVJxSUkzNjF4NndRWAoyYnQ1WWtsNEc3 ODhnOEwvdmhZWGZxYVFmV2dSNytuVjRVV09NOExiZWxhZ3Y3MDVFUnAxdzZjS29NRldVS0lGCmIr MElNdzVmMk1aYW9sVmRtSnVCOFNudDVlZjA5ZElMTUtGQnJqVDRyQWNwd25XSm9vQmJacG5WRHVC aXl2b2UKc0xJRExObnl6RmxlUkpNSGU2K1ZvVWxIOXQzcXZObER1MlMxNnBvOVJsckE3WDRoRGJP aXE1VXQranY1dGV2MQpEWEpHV0RUVGZySG9Tb2ZYdVlzM1ZWQjlGYlozYXpWZzdIdFdKRnd5dGpK d2VtdDlaVDB4MFNpTGlZQzVaQno2CnpWQVdXL3lxWkpFZjlXeTJxMzRSdVpEd0JESlVwdi9BcG1l aG5DM3dMU1UrdEkxYUNhQm5yV3NiYXNZVjFPenIKTmZXeThsTE01Ni9pNWljenh6c0RSNTBHMHJy SHg4WDc1RThaSXd2cXJ4bnlRQXZUbDI5MHlXL1JORzlLVFVidQpZM3ZWTEVtdjJWMkdQRngrQ0tt anRyT1cxclhReC85a0E5S0dwK1lGRkFSOEJuVE01ZmhzRkcwa1hWWTZmNmpVCmVJeG9JYTlKVUNK QTFhWFNlaitzdkU3bVk0aHFjVkd6YSszTzVPelB2dVNpMVRzemZaY3FkeFZOWE5WTEROV0oKYVlu RlAyajZKeklTWWh3V1Y0TnZpRFFJclo2K1FrZUdRNnNaaGJoS1BhR0dLSC9IaENsYXB5OGhvOFlt dGhWdwprWTBKK280Mk9BazE3VTgrVTB3QlFZbVhlQitTbDZLa1BDeXk3YnFJSkxHY3lsZjFCR1E9 Cj1Ebnh5Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============8466382684346206554==--