[PATCH] Suggestion: Related to BUG11494 - removed PRINT-line in 'extrahd.pl'

[PATCH] Suggestion: Related to BUG11494 - removed PRINT-line in 'extrahd.pl'

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

Just a suggestion - I don't want it to be forgotten - so I deleted
the useless(!?) line 51 in '/config/extrahd.pl'.

As shown in https://forum.ipfire.org/viewtopic.php?f=50&t=19563#p111055
PRINT-output somehow garbles bash-prompt.

Starting 'extrahd.pl'  from console:
...
root(a)ipfire: /var/ipfire/extrahd/bin # ./extrahd.pl scanhd ide
...

Leads to:
...
scanhd ideroot(a)ipfire: /var/ipfire/extrahd/bin #
^^^^^^^^^^
...

I think its just a forgotten debug line.

Jm2C - Best,
Matthias

Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
 config/extrahd/extrahd.pl | 2 --
 1 file changed, 2 deletions(-)

diff --git a/config/extrahd/extrahd.pl b/config/extrahd/extrahd.pl
index 3c6fa0280..3b57e9230 100644
--- a/config/extrahd/extrahd.pl
+++ b/config/extrahd/extrahd.pl
@@ -48,8 +48,6 @@ close FILE;
 ############################################################################################################################
 ############################################################################################################################
 
-print "$ARGV[0] $ARGV[1]";
-
 if ( "$ARGV[0]" eq "mount" ) {
 	system("/bin/cp -f /etc/fstab $fstab");
 
-- 
2.14.2

Re: [PATCH] Suggestion: Related to BUG11494 - removed PRINT-line in 'extrahd.pl'

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

Hi,

yes this is certainly debugging code.

I will merge this as soon as patchwork is back from being updated.

Best,
-Michael

On Tue, 2017-10-03 at 15:40 +0200, Matthias Fischer wrote:
> Just a suggestion - I don't want it to be forgotten - so I deleted
> the useless(!?) line 51 in '/config/extrahd.pl'.
> 
> As shown in https://forum.ipfire.org/viewtopic.php?f=50&t=19563#p111055
> PRINT-output somehow garbles bash-prompt.
> 
> Starting 'extrahd.pl'  from console:
> ...
> root(a)ipfire: /var/ipfire/extrahd/bin # ./extrahd.pl scanhd ide
> ...
> 
> Leads to:
> ...
> scanhd ideroot(a)ipfire: /var/ipfire/extrahd/bin #
> ^^^^^^^^^^
> ...
> 
> I think its just a forgotten debug line.
> 
> Jm2C - Best,
> Matthias
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  config/extrahd/extrahd.pl | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/config/extrahd/extrahd.pl b/config/extrahd/extrahd.pl
> index 3c6fa0280..3b57e9230 100644
> --- a/config/extrahd/extrahd.pl
> +++ b/config/extrahd/extrahd.pl
> @@ -48,8 +48,6 @@ close FILE;
>  #############################################################################
> ###############################################
>  #############################################################################
> ###############################################
>  
> -print "$ARGV[0] $ARGV[1]";
> -
>  if ( "$ARGV[0]" eq "mount" ) {
>  	system("/bin/cp -f /etc/fstab $fstab");
>  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]