From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] Suggestion: Related to BUG11494 - removed PRINT-line in 'extrahd.pl' Date: Wed, 04 Oct 2017 16:47:42 +0100 Message-ID: <1507132062.433.12.camel@ipfire.org> In-Reply-To: <20171003134025.24294-1-matthias.fischer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2491131853511341623==" List-Id: --===============2491131853511341623== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, yes this is certainly debugging code. I will merge this as soon as patchwork is back from being updated. Best, -Michael On Tue, 2017-10-03 at 15:40 +0200, Matthias Fischer wrote: > Just a suggestion - I don't want it to be forgotten - so I deleted > the useless(!?) line 51 in '/config/extrahd.pl'. >=20 > As shown in https://forum.ipfire.org/viewtopic.php?f=3D50&t=3D19563#p111055 > PRINT-output somehow garbles bash-prompt. >=20 > Starting 'extrahd.pl' from console: > ... > root(a)ipfire: /var/ipfire/extrahd/bin # ./extrahd.pl scanhd ide > ... >=20 > Leads to: > ... > scanhd ideroot(a)ipfire: /var/ipfire/extrahd/bin # > ^^^^^^^^^^ > ... >=20 > I think its just a forgotten debug line. >=20 > Jm2C - Best, > Matthias >=20 > Signed-off-by: Matthias Fischer > --- > config/extrahd/extrahd.pl | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/config/extrahd/extrahd.pl b/config/extrahd/extrahd.pl > index 3c6fa0280..3b57e9230 100644 > --- a/config/extrahd/extrahd.pl > +++ b/config/extrahd/extrahd.pl > @@ -48,8 +48,6 @@ close FILE; > ##########################################################################= ### > ############################################### > ##########################################################################= ### > ############################################### > =20 > -print "$ARGV[0] $ARGV[1]"; > - > if ( "$ARGV[0]" eq "mount" ) { > system("/bin/cp -f /etc/fstab $fstab"); > =20 --===============2491131853511341623== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl Mnlwa3R4Z0hudy8yK1FDUWNGQWxuVkFwNEFDZ2tRZ0hudy8yK1EKQ1FkR1NSQUFoY2E1NVY3cXVw TDRLQUFtKzRQazZSQmhaZDhNQkdtM0NFUFRaTFBOTkFIb05QRXl1WVZ1WW9jTwpUdlZmYTlnSlBs T1BxWlhIVzk3Y3pqdTVlbmViSXdBMXQ3bnpUZlJNV2tYdmMvYWJNckRqUUZKWGZqcU5LTy85CktU TzBpcm90RTJlbE12bEJnZ1ltMUFWSm5yUzIzS2N1S2Zaa0IyQmtxQjJMbHdzK3pTVmpCK1Rhb0hp ZXZiMVcKemppOTl6dkdCbWxoT0poWUxkZk9IRlN1b0VwbENpQTc3eUVMNkQyUWE3T3gxNUQzTEpk UitSMytnNzZmUnJ4Twp4VEVFaHJUWCtkbDZnWlVsLzVEVFk4ejRzQndxQS9waFBSUFIrck8zNDN0 ZG9FK3BwSUhxWXliWmY0R0F3VERkCjdFQTJwU1o0UUZMcHBJYlJkcmNmbmo3aE12UVp1RzdOYnNw WUREbHhsN2RDYVZjdGx3bFpZTjVXc1JVQjE1UWkKc25QVDRHMnl3SGdxWDI4YTJpYjJQRUc2aS80 UXlGQTBaa1BKTlZ1UlFXVlN6eTE4K09lYkY5NERmYjY5RGFGcgpSN1dMVDZFTFBDak1qSDZMOUt6 TlJwWElrL0ErTVpVRURmM0tnTTRmbXVwaTYzcnRxVm1FU2ltUnJZRGx0TUxECm1vQVVzYWJzTWpu cVdTdlVzYXIrVVZHSHk4emlacjJkeWZUYkwrdUg2bUxqK3FOa0YzL1FXanI4OC9kZG9oeFEKaTVX d0ZPbGM5ajREbVJkeTVMcUQyUDFzMUNDTHRHMWdOQlJwMG9jWXVSeldsTUFpRzFoekZWYTlSMjc4 SlBUegpVbURKTktJa05FSGdEVmNrbGtoeVA0WFRNdmxqU1FZWW9KOEdHbXNZc1RvS3dranRMdkE9 Cj1PWDdwCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============2491131853511341623==--