From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] proxy.cgi: Even more cosmetics for lazy ones (V3)
Date: Mon, 09 Oct 2017 15:34:35 +0100
Message-ID: <1507559675.4045.21.camel@ipfire.org>
In-Reply-To: <20170929090825.2054-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5480452845574098581=="
List-Id: <development.lists.ipfire.org>

--===============5480452845574098581==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2017-09-29 at 11:08 +0200, Matthias Fischer wrote:
> Another clickable link, this time for the 'Cache Manager Interface' - this =
one
> opens in a new window.
>=20
> Best,
> Matthias
>=20
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  html/cgi-bin/proxy.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
> index dd83bba73..ab490c3d3 100644
> --- a/html/cgi-bin/proxy.cgi
> +++ b/html/cgi-bin/proxy.cgi
> @@ -1118,7 +1118,7 @@ print <<END
>  	<td colspan=3D'4'><b>$Lang::tr{'advproxy cache management'}</b></td>
>  </tr>
>  <tr>
> -	<td class=3D'base'>$Lang::tr{'proxy cachemgr'}:</td>
> +	<td class=3D'base'><a href=3D'/cgi-bin/cachemgr.cgi\'
> target=3D\'_blank\'>$Lang::tr{'proxy cachemgr'}</a>:</td>
>  	<td><input type=3D'checkbox' name=3D'CACHEMGR' $checked{'CACHEMGR'}{'on'}
> /></td>

Why do you escape the '?

>  	<td class=3D'base'>$Lang::tr{'advproxy admin mail'}:</td>
>  	<td><input type=3D'text' name=3D'ADMIN_MAIL_ADDRESS'
> value=3D'$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>

-Michael

--===============5480452845574098581==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl
Mnlwa3R4Z0hudy8yK1FDUWNGQWxuYmlQc0FDZ2tRZ0hudy8yK1EKQ1FldFdnLy9la2ZyRTFsMFlE
d05hZHByNVY1ajZmT2ZMMHhoM1RSNGZNcnUvVENVMjB2LzUrOFpQS1NtNFd6dQpiRWJ3ZFNrYlBD
ZFIwNDRpYWRvTGxMM1B1TG9STlRpRHhLZ3VYQmN0TVRodzVCK0JmdmthanNPUmdQamFSVW1hCkVO
czRvSHpvL2ZRcDVpNGZjTnNDdDlCKzl3SkRNdEh6emZTa1RpUjdNS290VVp2alJBTUdoemd2M2F3
ZjdwMVEKMHQxM0lHS05TYTM5OE92SjlTMG1ibEdheU8waXlSd1FBdWV5VXRzU2JPNitTZDFSMlRN
aXpnRndhdHN1RDRQRApIWmc2VU5sYnEwWjJPejdnY09iRWhWaWxJMmpBMXRyNk52R0d1cHJ2S0VY
NUN3bVQydGVLQ0MyTitHL29yazd2CkRkaDJCMys4d1ZKbVJuQ0I0MGdwR1VjQ2xYRzBrWU9QdDZR
c2wzMHZMWU5DTDR4Y1ZueEY1LzlzL29CNEsySjgKWnQyNHlocUF1YVozbGRSWGlDOUpHSGRQOWVm
QlcwajRuTFlJTDdDdjNjM2F4OEVVU2RvWmEyY1ZDTVlYbk5BRwpWZ3pWcS9XVzlwemxHRG9DRmNB
L1lSRStlaVp4Z2NJZld5Y1I5TUJCVWZMQzk2QVVIblN1UlQ0ejNjK09HbFdXCmdxREw5a2hQMEk3
TVQ3Q1NNS001MHYxbXhVbWlsUmNmWmRUQWVqK2FDcDVkM2I4amI1NGxCSlBMcmlvdUlQN3YKdUJj
UkZlWnJ2VEx1TllZZTVkUkVJcjQ5bG1qbXFSTFVGUTl2Z0tjRFIvcUNBOXhlSHVvN2xDMUZITmJa
REt3QQpOQWpPV0ZUclBGU1ZhVFBXUlhtcnR5dzV4T3kwYUVaa3JocnV3bGRCT1ZONEZNaGdDOTQ9
Cj1DSkVlCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============5480452845574098581==--