From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] link to HTTPS version of www.ipfire.org in WebUI
Date: Mon, 06 Nov 2017 18:12:58 +0000 [thread overview]
Message-ID: <1509991978.4838.283.camel@ipfire.org> (raw)
In-Reply-To: <20171106181248.5574bfe0.peter.mueller@link38.eu>
[-- Attachment #1: Type: text/plain, Size: 4389 bytes --]
Thank you very much for submitting this patch. I suppose there is loads of
places where URLs are still pointing at our website over HTTP.
If you spot any more (also on the webapp), please send more patches.
Best,
-Michael
On Mon, 2017-11-06 at 18:12 +0100, Peter Müller wrote:
> Change links to www.ipfire.org in WebUI themes since the website
> now uses HTTPS.
>
> Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
> ---
> html/html/themes/darkdos/include/functions.pl | 2 +-
> html/html/themes/ipfire-legacy/include/functions.pl | 2 +-
> html/html/themes/ipfire/include/functions.pl | 6 +++---
> html/html/themes/maniac/include/functions.pl | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/html/html/themes/darkdos/include/functions.pl
> b/html/html/themes/darkdos/include/functions.pl
> index 7d803b6ad..ed3f546b0 100644
> --- a/html/html/themes/darkdos/include/functions.pl
> +++ b/html/html/themes/darkdos/include/functions.pl
> @@ -227,7 +227,7 @@ END
> if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
> print
> "<h1><span>$settings{'HOSTNAME'}.$settings{'DOMAINNAME'}</span></h1><br />";
> } else {
> - print "<h1><span><a href='http://www.ipfire.o
> rg' style='text-decoration: none;'>-= IPFire =-</a></span></h1><br />";
> + print "<h1><span><a href='https://www.ipfire.
> org' style='text-decoration: none;'>-= IPFire =-</a></span></h1><br />";
> }
> print <<END
> <h2>+ $h2 +</h2>
> diff --git a/html/html/themes/ipfire-legacy/include/functions.pl
> b/html/html/themes/ipfire-legacy/include/functions.pl
> index 528825329..26a8763c1 100644
> --- a/html/html/themes/ipfire-legacy/include/functions.pl
> +++ b/html/html/themes/ipfire-legacy/include/functions.pl
> @@ -227,7 +227,7 @@ END
> if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
> print
> "<h1><span>$settings{'HOSTNAME'}.$settings{'DOMAINNAME'}</span></h1><br />";
> } else {
> - print "<h1><span><a href='http://www.ipfire.o
> rg' style='text-decoration: none;'>IPFire</a></span></h1><br />";
> + print "<h1><span><a href='https://www.ipfire.
> org' style='text-decoration: none;'>IPFire</a></span></h1><br />";
> }
> print <<END
> <h2>$h2</h2>
> diff --git a/html/html/themes/ipfire/include/functions.pl
> b/html/html/themes/ipfire/include/functions.pl
> index 7f6000a46..9aec77497 100644
> --- a/html/html/themes/ipfire/include/functions.pl
> +++ b/html/html/themes/ipfire/include/functions.pl
> @@ -152,7 +152,7 @@ print <<END
> <body>
> <div id="header" class="fixed">
> <div id="logo">
> - <a href="http://www.ipfire.org" style="text-
> decoration: none;">
> + <a href="https://www.ipfire.org" style="text-
> decoration: none;">
> <img
> src="/themes/ipfire/images/tux2.png" style="float:left; margin-left: -3px;
> margin-top: -3px;"/>
> END
> ;
> @@ -205,8 +205,8 @@ print <<END;
>
> <div id="footer" class='bigbox fixed'>
> <span class="pull-right">
> - <a href="http://www.ipfire.org/"
> target="_blank"><strong>IPFire.org</strong></a> •
> - <a href="http://www.ipfire.org/donate"
> target="_blank">$Lang::tr{'support donation'}</a>
> + <a href="https://www.ipfire.org/"
> target="_blank"><strong>IPFire.org</strong></a> •
> + <a href="https://www.ipfire.org/donate"
> target="_blank">$Lang::tr{'support donation'}</a>
> </span>
>
> <strong>$system_release</strong>
> diff --git a/html/html/themes/maniac/include/functions.pl
> b/html/html/themes/maniac/include/functions.pl
> index 4866fcd0c..1c0aea1c4 100644
> --- a/html/html/themes/maniac/include/functions.pl
> +++ b/html/html/themes/maniac/include/functions.pl
> @@ -227,7 +227,7 @@ END
> if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
> print
> "<h1><span>$settings{'HOSTNAME'}.$settings{'DOMAINNAME'}</span></h1><br />";
> } else {
> - print "<h1><span><a href='http://www.ipfire.o
> rg' style='text-decoration: none;'>-= IPFire =-</a></span></h1><br />";
> + print "<h1><span><a href='https://www.ipfire.
> org' style='text-decoration: none;'>-= IPFire =-</a></span></h1><br />";
> }
> print <<END
> <h2>+ $h2 +</h2>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-06 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 17:12 Peter Müller
2017-11-06 18:12 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509991978.4838.283.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox