From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] display rDNS and GeoIP information for used nameservers
Date: Tue, 07 Nov 2017 11:37:50 +0000
Message-ID: <1510054670.4838.311.camel@ipfire.org>
In-Reply-To: <20171106190919.2f0f434f.peter.mueller@link38.eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6892373943320800722=="
List-Id: <development.lists.ipfire.org>

--===============6892373943320800722==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

this quite a nice idea, but I have one small problem here which I think could
potentially confuse the users more than it helps.

And that is anycast DNS servers.

So for example for the famous Google DNS 8.8.8.8 the GeoIP location would be =
US
which technically is correct, but I know for a fact that I am using an instan=
ce
that is located in the Telehouse which just a few miles away from me and not =
on
the other side of the big pond.

So can we do anything to make this better and should we?

-Michael

On Mon, 2017-11-06 at 19:09 +0100, Peter M=C3=BCller wrote:
> Display rDNS/PTR record and GeoIP information for used nameservers
> on the netexternal.cgi WebUI page. These information might be useful
> for debugging.
>=20
> Thanks to Matthias Fischer for style improvements.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)link38.eu>
> ---
>  html/cgi-bin/netexternal.cgi | 25 +++++++++++++++++++++++++
>  langs/de/cgi-bin/de.pl       |  1 +
>  langs/en/cgi-bin/en.pl       |  1 +
>  3 files changed, 27 insertions(+)
>=20
> diff --git a/html/cgi-bin/netexternal.cgi b/html/cgi-bin/netexternal.cgi
> index 299612d4c..cd2223ac6 100644
> --- a/html/cgi-bin/netexternal.cgi
> +++ b/html/cgi-bin/netexternal.cgi
> @@ -25,9 +25,13 @@ use strict;
>  #use warnings;
>  #use CGI::Carp 'fatalsToBrowser';
> =20
> +use IO::Socket;
> +use Geo::IP::PurePerl;
> +
>  require '/var/ipfire/general-functions.pl';
>  require "${General::swroot}/lang.pl";
>  require "${General::swroot}/header.pl";
> +require "${General::swroot}/geoip-functions.pl";
>  require "${General::swroot}/graphs.pl";
> =20
>  my %color =3D ();
> @@ -99,6 +103,12 @@ if ( $querry[0] ne~ ""){
>  						<strong>$Lang::tr{'nameserver
> '}</strong>
>  					</th>
>  					<th align=3D"center">
> +						<strong>$Lang::tr{'flag'}</st
> rong>
> +					</th>
> +					<th align=3D"center">
> +						<strong>$Lang::tr{'rdns'}</st
> rong>
> +					</th>
> +					<th align=3D"center">
>  						<strong>$Lang::tr{'status'}</
> strong>
>  					</th>
>  				</tr>
> @@ -138,10 +148,25 @@ END
>  		}
> =20
>  		my $table_colour =3D ($id++ % 2) ? $color{'color22'} :
> $color{'color20'};
> +	=09
> +		my $iaddr =3D inet_aton($nameserver);
> +		my $rdns =3D gethostbyaddr($iaddr, AF_INET);
> +		if (!$rdns) { $rdns =3D $Lang::tr{'lookup failed'}; }
> +
> +		my $gi =3D Geo::IP::PurePerl->new();
> +		my $ccode =3D $gi->country_code_by_name($nameserver);
> +		my $fcode =3D lc($ccode);
> +		my $flag_icon =3D &GeoIP::get_flag_icon($fcode);
> =20
>  		print <<END;
>  			<tr bgcolor=3D"$table_colour">
>  				<td>$nameserver</td>
> +				<td align=3D"center">
> +					<a href=3D"country.cgi#$fcode"><img
> src=3D"$flag_icon" border=3D"0" align=3D"absmiddle" alt=3D"$ccode" title=3D=
"$ccode"></a>
> +				</td>
> +				<td align=3D"center">
> +					$rdns
> +				</td>
>  				<td bgcolor=3D"$bgcolour" align=3D"center">
>  					<font
> color=3D"$colour"><strong>$message</strong></font>
>  				</td>
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index af96a6445..4cf866a3a 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -1951,6 +1951,7 @@
>  'quick playlist' =3D> 'Quick Playlist',
>  'ram' =3D> 'RAM-Speicher',
>  'random number generator daemon' =3D> 'Random Number Generator Daemon',
> +'rdns' =3D> 'rDNS',
>  'read bytes' =3D> 'Gelesene Bytes',
>  'read list' =3D> 'Liste der Leseberechtigten',
>  'real address' =3D> 'Reale Addresse',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 7e4f95ccf..946aba873 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -1989,6 +1989,7 @@
>  'quick playlist' =3D> 'Quick Playlist',
>  'ram' =3D> 'RAM',
>  'random number generator daemon' =3D> 'Random Number Generator Daemon',
> +'rdns' =3D> 'rDNS',
>  'read bytes' =3D> 'Read Bytes',
>  'read list' =3D> 'list with readonly hosts',
>  'real address' =3D> 'Real Address',

--===============6892373943320800722==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl
Mnlwa3R4Z0hudy8yK1FDUWNGQWxvQm13NEFDZ2tRZ0hudy8yK1EKQ1FmN21BLzhEZHcwNmlpY2xC
dmtLeDNVR3RQOG5wb3R0cXFEVHpTVlVGdzllTi9tMy9RdVBWTTRheVMzeUJnZApMS0o1cFVaa2NO
MVZDYUlSQ3dBQmdaMUhjcmNyZWdoZ1B3SFR1UTlnYzMyOTBNWGk1aUVPdVB6OForY1pabXpnCk9u
TUpCeU8rcURGcmg3b2cxRTh0OExtUkloSVdGSDF3WVFBR0dXWDVETGZTVHR1ZjFzK3BXOEtrd2x1
RU8xcnoKVFZwK1Z1YzkxbGxoNldTd3pqYjZyM1ZHL0Y5YndzTUlUU2ZmWHhZYjFBbVd5RzFNcnpI
aFpyc04yd0dUemJ6dApMc2R2SWg0R3RONVN5NGl3QTJxcFZzRHRCbkNIQVdiZnVZbWh5R0FUaHhN
SVhsRFR1TVJKNFZRaVB0dHZ3MEVJCmlaWVVwR2ptZ0YxWFlZRk51cytXZWJhaENzaUlGeGtVblMy
YWZnSksxdThRNExUVERVTHlRdTBMdHQrWENvK1YKZWllNC9CU2FHZlNBZmxBVFlZTFJGdnpYY0hI
ZHJwbml1ZDhaZXBvT2xqSE9DZzMwZHNsTU1FYUpFVytrc2VheQpIaEpKdmFibnRLSEt4UUl0OVJ3
b2dUbEM2MGM2RHEwMXlPTktvMmpRTllnK1ZpVm1GTWE4bWFFdEgyT25Xd2F2CjBaMGVuck1sNnB4
VTEzU2FGU2czS3J1eDlNTnh5QzJnNmpIdXJJcUN2VE1SNlVDVG5xSDZoUGZkNG5WS2lSc0EKTWs1
Z0ZKTktOOUJXQm5lR3R3MTBJZXZ4b1gzZmZnbWI2Mi9GWHBGdm1yZ3RFcG1FNlVKajZhY2dDSlNz
SEs2NQpTOGJUNVdOOEVhV0pDMEk5NTJxY1AyWHJER0xqZTJJSGtKVnI2d2QzSXhCQ2ZQMEgzV0E9
Cj1CWk5PCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============6892373943320800722==--