From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] display GeoIP information on active network connections in WebUI Date: Tue, 07 Nov 2017 23:07:07 +0000 Message-ID: <1510096027.2768.20.camel@ipfire.org> In-Reply-To: <20171107204242.15257272.peter.mueller@link38.eu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3829629961162103129==" List-Id: --===============3829629961162103129== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Basically this patch looks simple and good to me. But since we are using the perl module quite a bit, could we not put those few lines into a function so that if we need to change anything we do that everywhere at once? And secondly, I have some systems that have thousands of open connections very often to the same IP addresses. Could we not add a caching layer so that this isn't being looked up multiple times for the same IP address if that is an expensive operation? -Michael On Tue, 2017-11-07 at 20:42 +0100, Peter M=C3=BCller wrote: > Display the GeoIP flag for source and destination IP address > on the connection tracking table in WebUI. >=20 > This could possibly make network or firewall rule debugging easier. >=20 > Signed-off-by: Peter M=C3=BCller > --- > html/cgi-bin/connections.cgi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/html/cgi-bin/connections.cgi b/html/cgi-bin/connections.cgi > index 96f09012b..06dc74877 100644 > --- a/html/cgi-bin/connections.cgi > +++ b/html/cgi-bin/connections.cgi > @@ -23,6 +23,7 @@ use strict; > =20 > use Net::IPv4Addr qw( :all ); > use Switch; > +use Geo::IP::PurePerl; > =20 > # enable only the following on debugging purpose > #use warnings; > @@ -31,6 +32,7 @@ use Switch; > require '/var/ipfire/general-functions.pl'; > require "${General::swroot}/lang.pl"; > require "${General::swroot}/header.pl"; > +require "${General::swroot}/geoip-functions.pl"; > =20 > my $colour_multicast =3D "#A0A0A0"; > =20 > @@ -372,6 +374,7 @@ print < 3D"" > 3D"" > > +   > > 3D"" > 3D"" > @@ -386,6 +389,7 @@ print < 3D"" > 3D"" > > +   > > 3D"" > 3D"" > @@ -409,10 +413,16 @@ print < > $Lang::tr{'source ip and port'} > > + > + $Lang::tr{'country'} > + > > $Lang::tr{'dest ip and port'} > > > + $Lang::tr{'country'} > + > + > $Lang::tr{'download'} / >
$Lang::tr{'upload'} > > @@ -540,6 +550,16 @@ foreach my $line (@conntrack) { > my $bytes_in =3D format_bytes($bytes[0]); > my $bytes_out =3D format_bytes($bytes[1]); > =20 > + my $gi1 =3D Geo::IP::PurePerl->new(); > + my $ccode1 =3D $gi1->country_code_by_name($sip_ret); > + my $fcode1 =3D lc($ccode1); > + my $flag_icon1 =3D &GeoIP::get_flag_icon($fcode1); > + > + my $gi2 =3D Geo::IP::PurePerl->new(); > + my $ccode2 =3D $gi2->country_code_by_name($dip_ret); > + my $fcode2 =3D lc($ccode2); > + my $flag_icon2 =3D &GeoIP::get_flag_icon($fcode2); > +=09 > # Format TTL > $ttl =3D format_time($ttl); > =20 > @@ -601,6 +621,9 @@ foreach my $line (@conntrack) { > > $sport_extra > > + > + > + > > > $dip > @@ -613,6 +636,9 @@ foreach my $line (@conntrack) { > > $dport_extra > > + > + > + > > $bytes_in / $bytes_out > --===============3829629961162103129== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl Mnlwa3R4Z0hudy8yK1FDUWNGQWxvQ1BKc0FDZ2tRZ0hudy8yK1EKQ1FkZk93Ly9SYVZvanFUM2tL dUNMQ1BoaThwK2l1V3RuKzFlUnZnT0tIM1RsR25GT0pKZmJoZFpEenl5QzN6ZQpRNGNnU1lvbnBD bzFTR0tqSUMrS0gwZmsxektPemVLY3lVZFBQVnJodTQvYWVuNE9YQUk4UkE3MWVyZTNScytyClZl QkxkY0FGNWtCZG9nQ2xHaFBTY1NUR29hNzNSeGhKM3JwSmxEcjRNaWFxMHdxZlhVNSszUDVyb21h eUR2cWEKelhuT2ZLeUNLMXplMUNjbGgyamVPeVdTMlpsRERHNGkyVVNRT0tERDl4b3lOSWlaSEhu NWV4eEg1R1QyNzJQWQpVNEp6ZDAyaVBleXRUdFA5TFZOWFg1NWhIUThycUhJckh6OFlCdS9HdTJY ekNCWnB5a2tlUlY3NnExZFRuSU9NCkxmVmVGZnJ2bnJtRXNSdUNwVVNsUUcrS3JMenBjSHU4MnUv dEdRVk9rMDg4SzZiVVB4WDNDZVpjU3pBK1FmQVAKbkUwQmJtN0JXeHNVeVo4NjVuMWxyaXdESE9I RXdmZXN4R2pKcXpNdkVmOUlKUDJSbU4yamVLd3k1bSt5RXVybwpscjVGaTI5RUpjZ0J4Z3dMQXBx Ni94NGQ3c1NlT0NBYkYxVVdxZURSU3Evc2FNZ20wMUd5aS9Xay85ZFY0d2VXCnlZd3ZUWDB3c2lK b3NSSWpTOU5oTkZQUzVzUHlGK0RKYTJzMkNFZExRZDZMRGhwMlEwUUVXeStRd0FSVUtwbU0KaE9G dy90cmZsNGNtSFZFNVY5dmpRZlJoRk5rRUJFY3JQS0tkN1I5ckRJcENMS2hXdDJYUTdMNHVISHQ2 K3d0cgp0MFA5a013U1c0QWxTbldYem5sd0V1SmhpamZoQkREeU9ocFN3alVDSVhiM0tLcktCbW89 Cj11MFFVCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============3829629961162103129==--