From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] show IDS rule names correctly in WebUI log
Date: Tue, 21 Nov 2017 12:06:09 +0000
Message-ID: <1511265969.4838.563.camel@ipfire.org>
In-Reply-To: <20171120191314.4b55e2b5.peter.mueller@link38.eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3277188419351068424=="
List-Id: <development.lists.ipfire.org>

--===============3277188419351068424==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

the bug ID is good, but it didn't have a precise explanation either.

I just wanted this on the record so that we know what this patch was supposed=
 to
be doing.

Yes, please send again.

Best,
-Michael

On Mon, 2017-11-20 at 19:13 +0100, Peter M=C3=BCller wrote:
> Hello Michael,
>=20
> Emerging Threats changed some snort signature IDs to 5 digits
> a while, which were not displayed in the WebUI since "([0-9]{1,4})"
> did not match on it.
>=20
> This patch adjusts the regular expression so they are displayed
> correctly now.
>=20
> Should I send in a second version with this description? Thought
> the bug ID would be enough...
>=20
> Best regards,=20
> Peter M=C3=BCller
>=20
> > Hello,
> >=20
> > can you explain what this patch is supposed to change?
> >=20
> > -Michael
> >=20
> > On Sun, 2017-11-19 at 18:04 +0100, Peter M=C3=BCller wrote:
> > > Fixes #11519.
> > >=20
> > > Signed-off-by: Peter M=C3=BCller <peter.mueller(a)link38.eu>
> > > ---
> > >  html/cgi-bin/logs.cgi/ids.dat | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.=
dat
> > > index 44b3abdac..98176d690 100644
> > > --- a/html/cgi-bin/logs.cgi/ids.dat
> > > +++ b/html/cgi-bin/logs.cgi/ids.dat
> > > @@ -387,7 +387,7 @@ sub processevent
> > >  				}
> > >  				($title,$classification,$priority,$date,$
> > > time
> > > ,$srcip,$srcport,$destip,$destport, $sid) =3D
> > > ("n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a", "n/a");
> > >  				@refs =3D ();
> > > -				$_ =3D~ m/:([0-9]{1,4})\] (.*) \[\*\*\]/;
> > > +				$_ =3D~ m/:([0-9]{1,5})\] (.*) \[\*\*\]/;
> > >  				$title =3D &Header::cleanhtml($2,"y");
> > >  			}
> > >  			if ($_ =3D~ m/Classification: (.*)\] \[Priority:
> > > (\d)\]/) { =20
>=20
>=20

--===============3277188419351068424==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl
Mnlwa3R4Z0hudy8yK1FDUWNGQWxvVUZyRUFDZ2tRZ0hudy8yK1EKQ1FkQ3h3Ly9YRHA3Q0ZrcWc2
b2VuUGlVaHJpaWlHSTJCTUR5dUg1aEprS09VT2NodmltRGg0cVNqbThQZmZBRQpFRmxoQkhwRDds
MkZuWGFkSkZlRkRUb3ZnSllROGxDbUJLbXBxTjhMWDRKRE5SMHRZOVFKWTR6SUFBbmR1UStUCnZD
YkhvWGdOWkR5N3g1Sk5maG41ZUU4U0VSREEzamVzOVg5Q3J6Q2xlQ09CZHJDRENld1ZkUXBvSVl1
TVlXdHoKQ3laUjdjTnk5Zk9MN0NOanFPNWJDRTVRdlFxQUdzanhaNFIxeUprVWhmYlVEYU5MSGYr
dDVpSjlERGk2MUtpOQpMYkhQWkZpbUVKZ2M5YXduK2k2SUNWUHVGK2FJMHczWUlpcG9wNE5LNWVG
b2R2cjhqaW9YSFhvVkxqWEVLaVRZCmZabFdYalhrVEdiTElHTWhuaTJZYVpOS1ZwT2NQU3ptelc1
MnVMa2tNeFRKM25KQmNyYTA2Q2pXOVc4dWF2UE8KUGp2bVAwVjVBTG9yZWY5N1ppQ3FLZ0g1Yitu
c0RGZFAxR0k1Vmd6MHhxTG5lVmhYNUJ2NjYvb05lQXI2KzhOQQp5MkRUcUpoRlRhYmphVkNSUE1j
REFVdHlEaFJvd1FJVnhFbEZzVGNMZGViSnNOZWxyVFZ1a1hpM1M0a3RWaXdrCktiMytxNzF3OHhu
a0U2QmQxUlRnQ3FxNUFPWU9vMkVKY3MvSEMyYm5vWHI1RkE3M1FXektxdnRDTVlQTkVkb3YKMVIw
bjhJSEczWXBFbVg0cXF6ZFU1L1pmSFNrT2FyanVkZk1tczlkWkdiUjVGbEhHWUVmbVVtOTJzVC9p
TDZFUwpqL3FTMllWdkxjWFhBR0l4V3orbHd4dGJCYTZVb0dZQzAycldDQkZTM3I3S2pFQTBpQ1U9
Cj05ZTFyCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============3277188419351068424==--