From mboxrd@z Thu Jan 1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] amd-ucode: ship latest version amd ucode version
Date: Sat, 20 Jan 2018 14:44:25 +0000
Message-ID: <1516459465.3647.170.camel@ipfire.org>
In-Reply-To: <20180118181403.18245-1-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2975088127883895171=="
List-Id: <development.lists.ipfire.org>
--===============2975088127883895171==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Hi,
there are a few issues with this patch...
On Thu, 2018-01-18 at 19:14 +0100, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> config/rootfiles/common/i586/amd-microcode | 1 +
> config/rootfiles/common/x86_64/amd-microcode | 1 +
> lfs/amd-microcode | 79
> ++++++++++++++++++++++++++++
> make.sh | 1 +
> 4 files changed, 82 insertions(+)
> create mode 100644 config/rootfiles/common/i586/amd-microcode
> create mode 100644 config/rootfiles/common/x86_64/amd-microcode
> create mode 100644 lfs/amd-microcode
>=20
> diff --git a/config/rootfiles/common/i586/amd-microcode
> b/config/rootfiles/common/i586/amd-microcode
> new file mode 100644
> index 000000000..54dd311c8
> --- /dev/null
> +++ b/config/rootfiles/common/i586/amd-microcode
> @@ -0,0 +1 @@
> +lib/firmware/amd-ucode/microcode_amd_fam17h.bin
> diff --git a/config/rootfiles/common/x86_64/amd-microcode
> b/config/rootfiles/common/x86_64/amd-microcode
> new file mode 100644
> index 000000000..54dd311c8
> --- /dev/null
> +++ b/config/rootfiles/common/x86_64/amd-microcode
> @@ -0,0 +1 @@
> +lib/firmware/amd-ucode/microcode_amd_fam17h.bin
> diff --git a/lfs/amd-microcode b/lfs/amd-microcode
> new file mode 100644
> index 000000000..cec3a16a2
> --- /dev/null
> +++ b/lfs/amd-microcode
> @@ -0,0 +1,79 @@
> +##########################################################################=
###
> ##
> +# =
=20
> #
> +# IPFire.org - A linux based
> firewall #
> +# Copyright (C) 2007-2018 IPFire Team <info(a)ipfire.org> =
=20
> #
> +# =
=20
> #
> +# This program is free software: you can redistribute it and/or
> modify #
> +# it under the terms of the GNU General Public License as published
> by #
> +# the Free Software Foundation, either version 3 of the License,
> or #
> +# (at your option) any later
> version. #
> +# =
=20
> #
> +# This program is distributed in the hope that it will be
> useful, #
> +# but WITHOUT ANY WARRANTY; without even the implied warranty
> of #
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
> the #
> +# GNU General Public License for more
> details. #
> +# =
=20
> #
> +# You should have received a copy of the GNU General Public
> License #
> +# along with this program. If not, see <http://www.gnu.org/licenses/>. =
=20
> #
> +# =
=20
> #
> +##########################################################################=
###
> ##
> +
> +##########################################################################=
###
> ##
> +# Definitions
> +##########################################################################=
###
> ##
> +
> +include Config
> +
> +VER =3D 17h
This is not really a version number.
It is the name of the architecture/CPU family.
Maybe you can use a date.
> +
> +THISAPP =3D microcode_amd_fam$(VER)
> +DL_FILE =3D $(THISAPP).bin
> +DL_FROM =3D $(URL_IPFIRE)
> +DIR_APP =3D $(DIR_SRC)/$(THISAPP)
> +TARGET =3D $(DIR_INFO)/$(THISAPP)
> +SUP_ARCH =3D i586 x86_64
> +
> +##########################################################################=
###
> ##
> +# Top-level Rules
> +##########################################################################=
###
> ##
> +
> +objects =3D $(DL_FILE)
> +
> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
> +
> +$(DL_FILE)_MD5 =3D 4610fdded46938a4b094c5897e5c92b2
> +
> +install : $(TARGET)
> +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> +
> +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> +
> +md5 : $(subst %,%_MD5,$(objects))
> +
> +dist:.
> + $(PAK)
> +
> +##########################################################################=
###
> ##
> +# Downloading, checking, md5sum
> +##########################################################################=
###
> ##
> +
> +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> + @$(CHECK)
> +
> +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> + @$(LOAD)
> +
> +$(subst %,%_MD5,$(objects)) :
> + @$(MD5)
> +
> +##########################################################################=
###
> ##
> +# Installation Details
> +##########################################################################=
###
> ##
> +
> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> + @$(PREBUILD)
> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && mkdir -p $(DIR_APP) && mv
> $(DIR_DL)/$(DL_FILE) $(DIR_APP)/
> + # Copy the firmware file into the right position
> + cd $(DIR_APP) && cp -Rv $(DL_FILE) /lib/firmware/amd-ucode/
> + @rm -rf $(DIR_APP)
> + @$(POSTBUILD)
You are moving the source file here which would cause that every time it would
be re-downloaded again.
> diff --git a/make.sh b/make.sh
> index 3f10ffaec..992159105 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1121,6 +1121,7 @@ buildipfire() {
> ;;
> esac
> lfsmake2 intel-microcode
> + lfsmake2 amd-microcode
> lfsmake2 xtables-addons USPACE=3D"1"
> lfsmake2 openssl
> [ "${BUILD_ARCH}" =3D "i586" ] && lfsmake2 openssl KCFG=3D'-sse2'
--===============2975088127883895171==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0
LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ2dBZEZpRUU1L3JXNWwzR0dl
Mnlwa3R4Z0hudy8yK1FDUWNGQWxwalZja0FDZ2tRZ0hudy8yK1EKQ1FjcFZBLzZBZ3VnSWMxUzVP
SFlhTnNWVlVoTWxranN4RDhycHBtYkQra0JDTXozRDMxMUpZYTJ6bUFvNVZUdQozek1Hb3lHL2tK
UithdjRtREJGRWlEUURudW9YclBkTFU3N3VOUGMzOUYxMm0zVmdQbTlnd0lVMjdLT3I4QVZ6Ck1F
NFF2T0RCZHFyeEpzWUQzdXRzOGszVERHMnpPR1c2alFNZFYzL1p1bUQ1dkNRS3EybWpwZXgvYTBr
VjQvOCsKa2JJY1Ivd2tVWkpSeUVobHV3WW9RcmsvSVNUOVJzKysxMDVWbzlWY2tHb2tXZXdxQkFM
M3hJV1JUQnNXYVU1eQp4bmRiKytZYURRTS9kVmNOZWt2aGt2VTFkMDJ4Q1NYNVZzOVNQMWQvNTVF
bTZ1VnRCNzE1eEU4RklLMUVCSXUvCnNzSVF4c0FOaGZ6MEYyVEpYd1Z6dWR2bUlrbFhsRFIyZ01m
WVRKYkY3NTVFclByTGtqaFZTZTdia3htWGxydGsKbkc0M3NKcEExaVJGL1VXTmdUV2RyNkxZM1VV
YTU0QU10MWFkRVNaMkJVZzZmcTk3R2prNjBGVTRLeUVERWprdQpLY001MFJTbXV4M2loZDd1aitr
THNsbU9DNms2K1pWS3J6N0dYV0dkQWgvRXJjQmpiN1RlczVGdmVxekp5Yk5hCkRZT0tuSGFVeVJi
cTg4ZVJLWGlSVktITzJuOUV3N1NWOGpIdjExeDhJR1RiVzZYcGdZNUZSNkVaT2VYU0hwcmwKTkdU
ZVhsbGlKd1NrSFZvVXBDcFI3c211NS9QZlByQ1ZQOW5HTlNzSVBZSnJlRG9mU01rb1hCWm1lNitK
NHY2SwpMS0IvOUZOSFNraUFHMHU5WHp0R2N5M3hyNnZzL21kVGNJZW5vbEpnZUR1SGR4aEZpeWM9
Cj1lNUxmCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=
--===============2975088127883895171==--