public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* Typo in /var/ipfire/langs/en.pl
@ 2018-02-06 15:38 Tom Rymes
  2018-02-06 15:50 ` Michael Tremer
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Rymes @ 2018-02-06 15:38 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

I was just poking around in Bugzilla and noticed this old bug I had 
created. https://bugzilla.ipfire.org/show_bug.cgi?id=10595

Basically, it causes the names displayed for the Root and Host 
certificates on the IPSec page to have inconsistent capitalization 
("Host Certificate" vs. "Root certificate").

This is clearly not a big issue, but it's also an easy fix, and I 
thought "hey, I can fix this!" However, I'm not really certain what the 
best method would be to submit the change.

Any suggestions as to where I can start?

Tom

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Typo in /var/ipfire/langs/en.pl
  2018-02-06 15:38 Typo in /var/ipfire/langs/en.pl Tom Rymes
@ 2018-02-06 15:50 ` Michael Tremer
  2018-02-06 16:33   ` Tom Rymes
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Tremer @ 2018-02-06 15:50 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

Hi,

I just fixed that very quickly for you:

  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=cfa228c2f3c852ad6f5829fddfffe1f49a1f98f0

On Tue, 2018-02-06 at 10:38 -0500, Tom Rymes wrote:
> I was just poking around in Bugzilla and noticed this old bug I had 
> created. https://bugzilla.ipfire.org/show_bug.cgi?id=10595
> 
> Basically, it causes the names displayed for the Root and Host 
> certificates on the IPSec page to have inconsistent capitalization 
> ("Host Certificate" vs. "Root certificate").
> 
> This is clearly not a big issue, but it's also an easy fix, and I 
> thought "hey, I can fix this!" However, I'm not really certain what the 
> best method would be to submit the change.
> 
> Any suggestions as to where I can start?

This is where the documentation about sending patches is:

  https://wiki.ipfire.org/devel/submit-patches

Best,
-Michael

> 
> Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Typo in /var/ipfire/langs/en.pl
  2018-02-06 15:50 ` Michael Tremer
@ 2018-02-06 16:33   ` Tom Rymes
  2018-02-06 16:37     ` Michael Tremer
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Rymes @ 2018-02-06 16:33 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

Thanks, Michael. I was just confused as to just how complicated the 
process needed to be for such a simple fix.

I'll spend more time sifting through the patch documentation.

Tom

On 02/06/2018 10:50 AM, Michael Tremer wrote:
> Hi,
> 
> I just fixed that very quickly for you:
> 
>    https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=cfa228c2f3c852ad6f5829fddfffe1f49a1f98f0
> 
> On Tue, 2018-02-06 at 10:38 -0500, Tom Rymes wrote:
>> I was just poking around in Bugzilla and noticed this old bug I had
>> created. https://bugzilla.ipfire.org/show_bug.cgi?id=10595
>>
>> Basically, it causes the names displayed for the Root and Host
>> certificates on the IPSec page to have inconsistent capitalization
>> ("Host Certificate" vs. "Root certificate").
>>
>> This is clearly not a big issue, but it's also an easy fix, and I
>> thought "hey, I can fix this!" However, I'm not really certain what the
>> best method would be to submit the change.
>>
>> Any suggestions as to where I can start?
> 
> This is where the documentation about sending patches is:
> 
>    https://wiki.ipfire.org/devel/submit-patches
> 
> Best,
> -Michael
> 
>>
>> Tom


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Typo in /var/ipfire/langs/en.pl
  2018-02-06 16:33   ` Tom Rymes
@ 2018-02-06 16:37     ` Michael Tremer
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Tremer @ 2018-02-06 16:37 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

It actually is just one line to send the patch in the end, but setting up the
entire build environment, building the distribution, making changes, getting an
image, installing the image, perform testing, repeat thing is quite long.

-Michael

On Tue, 2018-02-06 at 11:33 -0500, Tom Rymes wrote:
> Thanks, Michael. I was just confused as to just how complicated the 
> process needed to be for such a simple fix.
> 
> I'll spend more time sifting through the patch documentation.
> 
> Tom
> 
> On 02/06/2018 10:50 AM, Michael Tremer wrote:
> > Hi,
> > 
> > I just fixed that very quickly for you:
> > 
> >    https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=cfa228c2f3c852ad6
> > f5829fddfffe1f49a1f98f0
> > 
> > On Tue, 2018-02-06 at 10:38 -0500, Tom Rymes wrote:
> > > I was just poking around in Bugzilla and noticed this old bug I had
> > > created. https://bugzilla.ipfire.org/show_bug.cgi?id=10595
> > > 
> > > Basically, it causes the names displayed for the Root and Host
> > > certificates on the IPSec page to have inconsistent capitalization
> > > ("Host Certificate" vs. "Root certificate").
> > > 
> > > This is clearly not a big issue, but it's also an easy fix, and I
> > > thought "hey, I can fix this!" However, I'm not really certain what the
> > > best method would be to submit the change.
> > > 
> > > Any suggestions as to where I can start?
> > 
> > This is where the documentation about sending patches is:
> > 
> >    https://wiki.ipfire.org/devel/submit-patches
> > 
> > Best,
> > -Michael
> > 
> > > 
> > > Tom
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-02-06 16:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 15:38 Typo in /var/ipfire/langs/en.pl Tom Rymes
2018-02-06 15:50 ` Michael Tremer
2018-02-06 16:33   ` Tom Rymes
2018-02-06 16:37     ` Michael Tremer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox