From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] proxy.cgi: strip newline from subnet parameter
Date: Sun, 11 Feb 2018 19:49:50 +0000
Message-ID: <1518378590.2498.5.camel@ipfire.org>
In-Reply-To: <20180211185122.9243-2-berny156@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8345859665977684897=="
List-Id: <development.lists.ipfire.org>

--===============8345859665977684897==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

This patch is fine.

On Sun, 2018-02-11 at 19:51 +0100, Bernhard Held wrote:
> $temp[1] might end with a newline; this is unavoidable when specifying
> serveral subnets. Thus, 'chomp $temp[1];' has to be moved before the
> comparisons with the green and blue subnets. Otherwise the comparison
> might always be true due to the newline.
> ---
>  html/cgi-bin/proxy.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
> index 6aa14e15a..ea3b41126 100644
> --- a/html/cgi-bin/proxy.cgi
> +++ b/html/cgi-bin/proxy.cgi
> @@ -3064,12 +3064,12 @@ END
>  			foreach (@templist)
>  			{
>  				@temp =3D split(/\//);
> +				chomp $temp[1];
>  				if (
>  					($temp[0] ne $netsettings{'GREEN_NETADDRESS'}) && ($temp[1] ne $netse=
ttings{'GREEN_NETMASK'}) &&
>  					($temp[0] ne $netsettings{'BLUE_NETADDRESS'}) && ($temp[1] ne $netset=
tings{'BLUE_NETMASK'})
>  					)
>  				{
> -					chomp $temp[1];
>  					print FILE " ||\n     (isInNet(myIpAddress(), \"$temp[0]\", \"$temp[1=
]\"))";
>  				}
>  			}

--===============8345859665977684897==--