From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Network::network_equal: fix definition check of array
Date: Sun, 11 Feb 2018 23:38:00 +0000
Message-ID: <1518392280.2498.23.camel@ipfire.org>
In-Reply-To: <20180211231930.12738-1-berny156@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2130200790006533132=="
List-Id: <development.lists.ipfire.org>

--===============2130200790006533132==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

this patch shows the following perl errors:

defined(@array) is deprecated at config/cfgroot/network-functions.pl line 114.
	(Maybe you should just omit the defined()?)
defined(@array) is deprecated at config/cfgroot/network-functions.pl line 114.
	(Maybe you should just omit the defined()?)

You can use the testsuite at the bottom of the file to confirm that the
functions are doing what they are supposed to do.

Best,
-Michael

On Mon, 2018-02-12 at 00:19 +0100, Bernhard Held wrote:
> ---
>  config/cfgroot/network-functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-f=
unctions.pl
> index 2902aabb0..3bf17b092 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -111,7 +111,7 @@ sub network_equal {
>  	my @bin1 =3D &network2bin($network1);
>  	my @bin2 =3D &network2bin($network2);
> =20
> -	if (!defined $bin1 || !defined $bin2) {
> +	if (!defined @bin1 || !defined @bin2) {
>  		return undef;
>  	}
> =20

--===============2130200790006533132==--