From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Network::network_equal: fix definition check of array
Date: Mon, 12 Feb 2018 11:08:36 +0000
Message-ID: <1518433716.2541.64.camel@ipfire.org>
In-Reply-To: <ceaad69d-3a26-00c6-44c6-6ce0927d52c4@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3322111112885731409=="
List-Id: <development.lists.ipfire.org>

--===============3322111112885731409==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

the perl version is a bit outdated that we are running on IPFire. It's perl
5.12.3: https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dlfs/perl;h=3D=
0c239318c39
15cdfbad3ff602b075bb425513bf3;hb=3DHEAD

I ran that testsuite with exactly that version of perl.

Best,
-Michael

On Mon, 2018-02-12 at 01:19 +0100, Bernhard Held wrote:
> On 02/12/2018 at 12:38 AM, Michael Tremer wrote:
> > Hello,
> >=20
> > this patch shows the following perl errors:
> >=20
> > defined(@array) is deprecated at config/cfgroot/network-functions.pl line
> > 114.
> > 	(Maybe you should just omit the defined()?)
> > defined(@array) is deprecated at config/cfgroot/network-functions.pl line
> > 114.
> > 	(Maybe you should just omit the defined()?)
>=20
> Interesting, I'm testing on IPFire 2.19. Here perl 5.12 prefers the '$'.
> My host with Perl 5.26 indeed prefers the '@' as well.
>=20
> Which perl versions apply for network-functions.pl?
>=20
> > You can use the testsuite at the bottom of the file to confirm that the
> > functions are doing what they are supposed to do.
>=20
> Thanks, this helps ;-)
>=20
> Regards,
> Bernhard

--===============3322111112885731409==--