From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v3 1/4] Network::network_equal: fix check if array is
 fully defined
Date: Wed, 14 Feb 2018 22:11:20 +0000
Message-ID: <1518646280.6463.3.camel@ipfire.org>
In-Reply-To: <20180214193522.26880-2-berny156@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6003256591938258024=="
List-Id: <development.lists.ipfire.org>

--===============6003256591938258024==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, 2018-02-14 at 20:35 +0100, Bernhard Held wrote:
> Correctly check length of list.
> Credit to Bernhard Bitsch for pointing in the right direction.
> ---
>  config/cfgroot/network-functions.pl | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-f=
unctions.pl
> index 2902aabb0..070e14d0f 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -111,8 +111,9 @@ sub network_equal {
>  	my @bin1 =3D &network2bin($network1);
>  	my @bin2 =3D &network2bin($network2);
> =20
> -	if (!defined $bin1 || !defined $bin2) {
> -		return undef;
> +	unless (scalar @bin1 =3D=3D 2 &&
> +	        scalar @bin2 =3D=3D 2) {
> +		return;
>  	}

This is actually quite a good way to probably check for the expected
result.

> =20
>  	if ($bin1[0] eq $bin2[0] && $bin1[1] eq $bin2[1]) {

-Michael

--===============6003256591938258024==--