From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v3 2/4] Network::network2bin: return an empty list in case
 of error
Date: Wed, 14 Feb 2018 22:12:12 +0000
Message-ID: <1518646332.6463.4.camel@ipfire.org>
In-Reply-To: <20180214193522.26880-3-berny156@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8463363459115864668=="
List-Id: <development.lists.ipfire.org>

--===============8463363459115864668==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

did you check if any other functions need to be changed in order to
reflect this change?

Many functions use the output of this one.

-Michael

On Wed, 2018-02-14 at 20:35 +0100, Bernhard Held wrote:
> 'return undef;' will always return a single value 'undef' even in list cont=
ext.
>=20
> sub foo { return undef }
> if ( my @x =3D foo() ) {
> 	print "oops, we think we got a result";
> }
> ---
>  config/cfgroot/network-functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-f=
unctions.pl
> index 070e14d0f..7cd56f799 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -139,7 +139,7 @@ sub network2bin($) {
>  	my $netmask_bin =3D &ip2bin($netmask);
> =20
>  	if (!defined $address_bin || !defined $netmask_bin) {
> -		return undef;
> +		return ();
>  	}
> =20
>  	my $network_start =3D $address_bin & $netmask_bin;

--===============8463363459115864668==--