From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] OpenVPN: Introduce new AES-GCM cipher for N2N and RW
Date: Thu, 15 Feb 2018 10:42:39 +0000 [thread overview]
Message-ID: <1518691359.15001.29.camel@ipfire.org> (raw)
In-Reply-To: <1518670974.19288.8.camel@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
Hi,
On Thu, 2018-02-15 at 06:02 +0100, ummeegge wrote:
> Hello,
>
> Am Mittwoch, den 14.02.2018, 20:20 +0000 schrieb Michael Tremer:
> > Hi,
> >
> > this patch is actually quite big and introduces a new feature by
> > adding AES-GCM.
> > It would have been better to get the necessary stuff done first.
>
> Should i split the java stuff (if it is in general usefull) in a
> separate patch ? Can also split N2N from the Roadwarrior patch but trhe
> changes are pretty equal and straight forward ?
No, leave this in there. That just creates some extra work. But consider that JS
is a not a strict requirement in the webUI. And we do have jQuery if you want to
use that.
> We can leave this patch behind, most important for me was feedback with
> this. Have send the most necessary stuff already.
>
> Greetings,
>
> Erik
next prev parent reply other threads:[~2018-02-15 10:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 12:45 [PATCH] " Erik Kapfer
2018-02-14 14:28 ` ummeegge
2018-02-14 14:40 ` [PATCH v2] " Erik Kapfer
2018-02-14 19:11 ` ummeegge
2018-02-14 20:23 ` Michael Tremer
2018-02-15 6:09 ` ummeegge
2018-02-15 10:59 ` Michael Tremer
2018-02-15 13:30 ` ummeegge
2018-02-14 20:20 ` Michael Tremer
2018-02-15 5:02 ` ummeegge
2018-02-15 10:42 ` Michael Tremer [this message]
2018-02-15 13:35 ` ummeegge
2018-02-25 13:49 ` [PATCH v3] OpenVPN: New " Erik Kapfer
2018-02-25 17:06 ` Michael Tremer
2018-02-26 6:48 ` ummeegge
2018-02-26 10:24 ` Michael Tremer
2018-02-27 6:23 ` ummeegge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518691359.15001.29.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox