Re: [PATCH v2] OpenVPN: Introduce new AES-GCM cipher for N2N and RW

[ummeegge <ummeegge@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

Hello,

#Am Donnerstag, den 15.02.2018, 10:42 +0000 schrieb Michael Tremer:
> Hi,
> 
> On Thu, 2018-02-15 at 06:02 +0100, ummeegge wrote:
> > 
> > Hello,
> > 
> > Am Mittwoch, den 14.02.2018, 20:20 +0000 schrieb Michael Tremer:
> > > 
> > > Hi,
> > > 
> > > this patch is actually quite big and introduces a new feature by
> > > adding AES-GCM. 
> > > It would have been better to get the necessary stuff done first.
> > Should i split the java stuff (if it is in general usefull) in a
> > separate patch ? Can also split N2N from the Roadwarrior patch but
> > trhe
> > changes are pretty equal and straight forward ?
> No, leave this in there. That just creates some extra work.
OK.

>  But consider that JS
> is a not a strict requirement in the webUI. And we do have jQuery if
> you want to
> use that.
Good to know will give it a try but i need to take a deeper look into
the jQuery thing then.

Have also already added your other suggestions for the cipher list
description.


Thanks for the feedback.

Greetings,

Erik