public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Alexander Marx <alexander.marx@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] BUG11695: Adding/editing rules with preset broken
Date: Thu, 24 May 2018 14:26:04 +0200	[thread overview]
Message-ID: <1527164764-17533-1-git-send-email-alexander.marx@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

added another check to fill same ports in source and destination when a custom service is selected.

Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
Reported-by: erik(a)vanlinsteeict.nl
---
 html/cgi-bin/firewall.cgi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index 499f279..d17afab 100644
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -757,6 +757,7 @@ sub checkrule
 				}
 			}
 			if($fwdfwsettings{'nat'} eq 'dnat' && $fwdfwsettings{'dnatport'} eq ''){$fwdfwsettings{'dnatport'}=$custsrvport;}
+			if($fwdfwsettings{'nat'} eq 'dnat' && $fwdfwsettings{'grp3'} eq 'cust_srv'){$fwdfwsettings{'dnatport'}=$custsrvport;}
 		}
 		#check if DNAT port is multiple
 		if($fwdfwsettings{'nat'} eq 'dnat' && $fwdfwsettings{'dnatport'} ne ''){
-- 
2.7.4


             reply	other threads:[~2018-05-24 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 12:26 Alexander Marx [this message]
2018-05-24 14:47 ` Michael Tremer
2021-07-15 16:07 ` Stefan Schantl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527164764-17533-1-git-send-email-alexander.marx@ipfire.org \
    --to=alexander.marx@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox