public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Set default of 730 days for client certificate validity
Date: Mon, 18 Jun 2018 17:02:45 +0200	[thread overview]
Message-ID: <1529334165.8691.6.camel@ipfire.org> (raw)
In-Reply-To: <73f402b1cb1d7296da8dc15e90cd07d420f84daa.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]

Yes, the renewal button is a lot more work, am currently not 100% clear
howto accomplish that, will need more time and other thoughts for that.

Thanks for looking through that.

Best,

Erik

Am Montag, den 18.06.2018, 15:50 +0100 schrieb Michael Tremer:
> Okay, this looks good.
> 
> I guess the renewal button is a lot more work and would be done
> separately.
> 
> Thanks for doing this one so quickly!
> 
> Best,
> -Michael
> 
> On Mon, 2018-06-18 at 16:41 +0200, Erik Kapfer wrote:
> > 
> > Since OpenSSL 1.1.0x it is required to set a value for the 'valid
> > til (days)'
> > field.
> > The WUI delivers now a guide value of two years.
> > 
> > Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
> > ---
> >  html/cgi-bin/ovpnmain.cgi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> > index 1c2a810..b3122a4 100644
> > --- a/html/cgi-bin/ovpnmain.cgi
> > +++ b/html/cgi-bin/ovpnmain.cgi
> > @@ -4451,7 +4451,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
> >  	$cgiparams{'CERT_CITY'}         =
> > $vpnsettings{'ROOTCERT_CITY'};
> >  	$cgiparams{'CERT_STATE'}        =
> > $vpnsettings{'ROOTCERT_STATE'};
> >  	$cgiparams{'CERT_COUNTRY'}      =
> > $vpnsettings{'ROOTCERT_COUNTRY'};
> > -	$cgiparams{'DAYS_VALID'}     	=
> > $vpnsettings{'DAYS_VALID'};
> > +	$cgiparams{'DAYS_VALID'}     	=
> > $vpnsettings{'DAYS_VALID'} =
> > '730';
> >      }
> >  
> >      VPNCONF_ERROR:

      reply	other threads:[~2018-06-18 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 14:41 Erik Kapfer
2018-06-18 14:50 ` Michael Tremer
2018-06-18 15:02   ` ummeegge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529334165.8691.6.camel@ipfire.org \
    --to=ummeegge@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox