From mboxrd@z Thu Jan  1 00:00:00 1970
From: Erik Kapfer <erik.kapfer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 [PATCH] OpenVPN: Prevent that a Roadwarrior name will be set two times
Date: Mon, 18 Jun 2018 17:32:57 +0200
Message-ID: <1529335977-31444-1-git-send-email-erik.kapfer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6138188736618348726=="
List-Id: <development.lists.ipfire.org>

--===============6138188736618348726==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Fixes bug #11307

Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
---
 html/cgi-bin/ovpnmain.cgi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 947cbe9..0bc28ce 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -4180,6 +4180,16 @@ if ($cgiparams{'TYPE'} eq 'net') {
 		}
 	    }
 
+		# Check for RW if client name is already set
+		if ($cgiparams{'TYPE'} eq 'host') {
+			foreach my $key (keys %confighash) {
+				if ($confighash{$key}[1] eq $cgiparams{'NAME'}) {
+					$errormessage = $Lang::tr{'a connection with this name already exists'};
+					goto VPNCONF_ERROR;
+				}
+			}
+		}
+
 	    # Replace empty strings with a .
 	    (my $ou = $cgiparams{'CERT_OU'}) =~ s/^\s*$/\./;
 	    (my $city = $cgiparams{'CERT_CITY'}) =~ s/^\s*$/\./;
-- 
2.7.4


--===============6138188736618348726==--