Re: ipblacklist V2

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3600 bytes --]

Hello,

> On 9 Feb 2022, at 22:14, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Rob,
> 
> On 09/02/2022 22:43, Rob Brewer wrote:
>> Hi Adolf,
>> 
>> Thank you for the kind comments in your earlier post and I'm pleased that
>> ipblacklist will be incorporated into IPFire. From what I'm seeing here it
>> will be a very worthwhile addition.  I have been looking through the Wiki
>> documentation for submitting patches and it looks fairly explanatory but
>> will probably need your help  to keep me in the right place.
> Just ask when you have any questions.
>> Adolf Belka wrote:
>> 
>>> Hi Rob,
>>> 
>>> In your communication below about the various patches, it sounded to me
>>> like you are suggesting that some of the patches could be taken from the
>>> earlier patchset because they have not changed. My apologies if I have
>>> misread it.
>>> 
>> I think that is correct. The majority of Tim's V2 patches can be
>> incorporated without changes.
>> 
>>> I believe that it would be better to submit a complete patchset now, where
>>> you include all patches, even if they haven't changed from earlier. This
>>> would make it much easier for tracking the status of the patches within
>>> patchwork and knowing what was included at a later date if looking back.
>>> So Tim's old patchset would be marked as superseded in patchwork and yours
>>> would take over and would be named as a v3 version.
>>> 
>> That's OK but it'll get me a couple of days to get my head around submitting
>> patches and getting the correct build environment set up. I presume you
>> would need patches against the next development load
>> (git checkout -b next -t origin/next) which I will have to set up.
> That is correct.
>>> Information on submitting the patches is in the wiki and if needed I can
>>> provide the appropriate links. If you have any questions on or problems
>>> with the patch submission process then just let me know.
>>> 
>> Thanks Adolf, I've read some of the docs. It mostly looks OK but when I get
>> around to submitting patches I think I'll need some help on submitting the
>> Build infrastructure patches and I don't have a clue how to generate the
>> lang files.
> 
> For the languages that are not provided then the default in IPFire is that the English version will be used. This is also the case if some but not all entries are translated. The untranslated entries stay as English.If there are languages where there are no files then you don't have to worry about them.  IPFire users who are native speakers usually over time provide the translations, either as patches or as files that one of us can create patches from.

Let’s not worry about any other language than English for now. Everyone on the team can handle this during the development process and we should translate everything in the end. Otherwise we might change a string or add another checkbox somewhere and we need to reach out to the native speakers of the other languages for just one sentence.

We have lots of native German speakers on here, so that won’t be a problem. Stéphane is a native French speaker who regularly updates the French translation and to whom we should reach out to when the time is right :) Otherwise the language support in IPFire is pretty much best-effort only.

-Michael

> 
> I will send you tomorrow the commands you need to run for the language files after the build command has been completed.
> 
>> It looks like the first step will be difficult but then hopefully gets
>> easier.
>> 
>> Regards
>> 
>> Rob