Re: [PATCH] OpenVPN: Prevent internal server error cause of bad header wrapper

[ummeegge <ummeegge@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

Hi,
just wanted to know if this fix will be applied ?

Best,

Erik


Am Donnerstag, den 21.06.2018, 11:12 +0200 schrieb Erik Kapfer:
> This fixes #11772 .
> 
> If the X509 are deleted, the openvpnctrl output generates a bad
> header wrapper error from the CGI
> which causes an internal server error. The redirection of the
> openvpnctrl output fixes this.
> 
> Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
> ---
>  html/cgi-bin/ovpnmain.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 4bc3473..5cd19a0 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -1181,7 +1181,7 @@ SETTINGS_ERROR:
>  	    delete $confighash{$cgiparams{'$key'}};
>  	}
>  
> -	system ("/usr/local/bin/openvpnctrl -drrd $name");
> +	system ("/usr/local/bin/openvpnctrl -drrd $name
> &>/dev/null");
>      }
>      while ($file = glob("${General::swroot}/ovpn/ca/*")) {
>  	unlink $file;